Skip to content

Conversation

@crazytonyli
Copy link
Contributor

There are a few updates in wordpress-rs. Most of the changes in this PR are adopting API changes.

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@crazytonyli crazytonyli added this to the 25.9 milestone Apr 9, 2025
@crazytonyli crazytonyli requested review from jkmassel and kean April 9, 2025 07:09
@dangermattic
Copy link
Collaborator

3 Warnings
⚠️ Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 9, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27260
VersionPR #24437
Bundle IDorg.wordpress.alpha
Commit6b7e96f
Installation URL0h4o11lpb0kc8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 9, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27260
VersionPR #24437
Bundle IDcom.jetpack.alpha
Commit6b7e96f
Installation URL3poqi841g1k7o
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@crazytonyli crazytonyli force-pushed the update-wordpress-rs-login-spec branch from c372ca0 to 7ff6d6d Compare April 9, 2025 23:36

@MainActor
func authenticate(url: URL, callbackURL: URL, from anchor: ASPresentationAnchor) async throws -> URL {
let provider = WebAuthenticationPresentationAnchorProvider(anchor: anchor)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can actually just pass in ASPresentationAnchor() here – no need to pass something down the whole hierarchy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was this crash, which I couldn't reproduce. I suspect the crash was due to using a new window instance. So I try to pass an existing window down to the web authentication session instance, instead of creating a new one.

@crazytonyli crazytonyli enabled auto-merge April 10, 2025 22:30
@crazytonyli crazytonyli added this pull request to the merge queue Apr 10, 2025
Merged via the queue into trunk with commit 733d5a6 Apr 10, 2025
31 checks passed
@crazytonyli crazytonyli deleted the update-wordpress-rs-login-spec branch April 10, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants