-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Update wordpress-rs to the latest release #24437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27260 | |
| Version | PR #24437 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 6b7e96f | |
| Installation URL | 0h4o11lpb0kc8 |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27260 | |
| Version | PR #24437 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 6b7e96f | |
| Installation URL | 3poqi841g1k7o |
c372ca0 to
7ff6d6d
Compare
|
|
||
| @MainActor | ||
| func authenticate(url: URL, callbackURL: URL, from anchor: ASPresentationAnchor) async throws -> URL { | ||
| let provider = WebAuthenticationPresentationAnchorProvider(anchor: anchor) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can actually just pass in ASPresentationAnchor() here – no need to pass something down the whole hierarchy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was this crash, which I couldn't reproduce. I suspect the crash was due to using a new window instance. So I try to pass an existing window down to the web authentication session instance, instead of creating a new one.


There are a few updates in wordpress-rs. Most of the changes in this PR are adopting API changes.
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: