Gravatar Quick Editor as My Profile editor #24583

etoledom · 2025-06-11T20:31:04Z

Description

This PR changes the previous MyProfileViewController with the Gravatar Quick Editor to edit the My Profile fields.

Testing instructions

Go to Me tab
Tap on the avatar view
- Check that the Quick Editor is presented on Avatar Picker mode
- Check that selecting a new avatar updates the current avatar on Jetpack side
Go back
Tap on My Profile
- Check that the Quick Editor is presented on About Editor mode (profile fields editor)
Update all the fields
Go back
- Check that the display name has change on the My Profile tab header
- Check on WP.com that the other fields have been updated acordingly

Consider testing the following yourself before requesting a review:

Compatibility with WordPress.com sites and self-hosted Jetpack sites
Both portrait and landscape orientations
Light and dark modes
Dynamic font sizes: larger, smaller and bold text
High contrast mode
Screen reader experience (e.g., VoiceOver)
Languages with large words or with letters/accents not frequently used in English
Right-to-left languages layout
Multi-tasking: split view and slide over

-->

etoledom · 2025-06-11T20:33:36Z

WordPress/Classes/ViewRelated/Me/My Profile/MyProfileHeaderView.swift

    @objc private func gravatarButtonTapped() {
-        guard let email = gravatarEmail,
-              let presenter = GravatarQuickEditorPresenter(email: email),
-              let presentingViewController else { return }
-        presenter.presentQuickEditor(on: presentingViewController)
+        guard
+            let presenter = GravatarQuickEditorPresenter(),
+            let presentingViewController
+        else { return }
+        presenter.presentQuickEditor(on: presentingViewController, scope: .avatarPicker())
    }
 }


I believe that this class and MyProfileViewController related types are no longer in use.

Should we clean up?

If you could remove MyProfileViewController and the related types, that would be ideal.

dangermattic · 2025-06-11T20:33:57Z

	2 Warnings
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

wpmobilebot · 2025-06-11T20:45:08Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`27962`
	Version	`PR #24583`
	Bundle ID	`org.wordpress.alpha`
	Commit	`78b9126`
	Installation URL	705b1hlvgk5oo

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2025-06-11T20:45:13Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`27962`
	Version	`PR #24583`
	Bundle ID	`com.jetpack.alpha`
	Commit	`78b9126`
	Installation URL	2mq702na5nk5g

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

kean

Hey, I tested the editor on iPhone, and it worked well.

There is a little bit of a UX issue due to a large, non-scrollable header that makes the form much smaller than it can be:

It's especially visible with accessibility fonts on:

The email field also sticks out with large fonts. I'd suggest displaying in inside the header "card" below the name.

I haven't tested the iPad version. I presume the form is shown in a "form" modal?

kean · 2025-06-12T12:56:06Z

WordPress/Classes/ViewRelated/Me/My Profile/MyProfileHeaderView.swift

    @objc private func gravatarButtonTapped() {
-        guard let email = gravatarEmail,
-              let presenter = GravatarQuickEditorPresenter(email: email),
-              let presentingViewController else { return }
-        presenter.presentQuickEditor(on: presentingViewController)
+        guard
+            let presenter = GravatarQuickEditorPresenter(),
+            let presentingViewController
+        else { return }
+        presenter.presentQuickEditor(on: presentingViewController, scope: .avatarPicker())
    }
 }


If you could remove MyProfileViewController and the related types, that would be ideal.

AdamGrzybkowski · 2025-06-12T16:18:00Z

Hey folks,

@nbradbury mentioned here that he likes combined avatarAndPicker scope. I think this is something that should be synced between iOS and Android. What are your thoughts about it?

…ditor

etoledom · 2025-06-13T21:49:21Z

Thank you @kean for the review!

We implemented a few changes taking into consideration reviews from Android and iOS PRs.
The changes are detailed here..

Regarding to your feedback, we have:

Removed the email from the top of the view, giving more vertical space.
The Profile card won't increase its size for dynamic type sizes beyond xxxl.
Removed the Profile card when the keyboard is present and the dynamic type size is Accessibility 3 or higher.

Besides this, I have removed from the project the types which have become obsolete.

We also wanted to mention that we have another alternative grid layout for the Avatar picker.
The alternatives can be seen here. We are currently using the "layout 3": Horizontal scrolling with intrinsic height size.

Regarding iPad, yes, it will present as a form modal:

…ditor

etoledom · 2025-06-18T10:48:11Z

@kean - Ready for another look 👀

kean

LGTM

Minor comments:

I still find it strange that only a small portion of the screen is scrollable while the rest isn’t. Additionally, the scroll indicator seems too far from the right edge. I recommend making the entire screen scrollable, including the header. It would also be helpful to move the Gravatar logo elsewhere and place the "Save" button in the navigation bar. This change would help save vertical space and align with the standard design for these types of forms in the app. If this isn't the direction you want to take, that's okay, but it doesn't follow typical native app conventions.
The notice is shown too close to the keyboard

Hey, @crazytonyli , do you want to take a second look at this PR?

crazytonyli · 2025-06-22T23:22:58Z

Modules/Package.swift

        .package(url: "https://github.com/Automattic/Automattic-Tracks-iOS", from: "3.5.2"),
        .package(url: "https://github.com/Automattic/AutomatticAbout-swift", from: "1.1.5"),
-        .package(url: "https://github.com/Automattic/Gravatar-SDK-iOS", from: "3.2.0"),
+        .package(url: "https://github.com/Automattic/Gravatar-SDK-iOS", revision: "ce04275c6237131576f424a215197bfaeaefc416"),


Just a reminder to update the commit to a tag.

…ditor

etoledom · 2025-06-23T18:24:09Z

Thank you all for the reviews!
We are aware of the existing issues with the current UI, and we will make a bigger revision of it later on, most probably based on the UI of the new Gravatar native App we started working on recently.

I have updated the reference to the latest release and will merge after CI gets ✅

🙏

…ditor

sonarqubecloud · 2025-06-24T07:59:07Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

etoledom added 2 commits June 11, 2025 22:18

Using Gravatar Quick Editor as My Profile editor

550213a

Update Gravatar SDK reference

43362a2

etoledom requested a review from kean June 11, 2025 20:31

etoledom self-assigned this Jun 11, 2025

etoledom added the Gravatar Gravatar SDK related updates label Jun 11, 2025

etoledom commented Jun 11, 2025

View reviewed changes

etoledom marked this pull request as draft June 11, 2025 20:35

kean reviewed Jun 12, 2025

View reviewed changes

etoledom and others added 4 commits June 13, 2025 17:39

Update Gravatar version

890df28

Using Avatar & About scopes on Gravatar Quick Editor

86e12a7

Removing types not longer used

cef3a01

Merge branch 'trunk' into proposal/gravatar-quick-editor-as-profile-e…

4ca5126

…ditor

etoledom requested a review from kean June 16, 2025 09:21

etoledom marked this pull request as ready for review June 18, 2025 09:28

Merge branch 'trunk' into proposal/gravatar-quick-editor-as-profile-e…

f0a7ad4

…ditor

kean approved these changes Jun 18, 2025

View reviewed changes

crazytonyli approved these changes Jun 22, 2025

View reviewed changes

etoledom added 2 commits June 23, 2025 20:16

Update Gravatar SDK to v3.4.0

4f9370d

Merge branch 'trunk' into proposal/gravatar-quick-editor-as-profile-e…

647c62f

…ditor

etoledom added 2 commits June 23, 2025 22:44

Merge branch 'trunk' into proposal/gravatar-quick-editor-as-profile-e…

5d2913c

…ditor

Merge branch 'trunk' into proposal/gravatar-quick-editor-as-profile-e…

78b9126

…ditor

etoledom enabled auto-merge June 24, 2025 07:56

etoledom added this pull request to the merge queue Jun 24, 2025

Merged via the queue into trunk with commit 90e979e Jun 24, 2025
32 of 34 checks passed

etoledom deleted the proposal/gravatar-quick-editor-as-profile-editor branch June 24, 2025 08:46

Gravatar Quick Editor as My Profile editor #24583

Gravatar Quick Editor as My Profile editor #24583

Uh oh!

Conversation

etoledom commented Jun 11, 2025

Description

Testing instructions

Uh oh!

etoledom Jun 11, 2025

Choose a reason for hiding this comment

Uh oh!

kean Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

dangermattic commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kean left a comment

Choose a reason for hiding this comment

Uh oh!

kean Jun 12, 2025

Choose a reason for hiding this comment

Uh oh!

AdamGrzybkowski commented Jun 12, 2025

Uh oh!

etoledom commented Jun 13, 2025

Uh oh!

etoledom commented Jun 18, 2025

Uh oh!

kean left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

crazytonyli Jun 22, 2025

Choose a reason for hiding this comment

Uh oh!

etoledom commented Jun 23, 2025

Uh oh!

sonarqubecloud bot commented Jun 24, 2025

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dangermattic commented Jun 11, 2025 •

edited

Loading

wpmobilebot commented Jun 11, 2025 •

edited

Loading

wpmobilebot commented Jun 11, 2025 •

edited

Loading

kean left a comment •

edited

Loading