Skip to content

Reader: Show error description when failing to load posts #25017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2025
+8 −7
Merged

Reader: Show error description when failing to load posts #25017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf427fe
Reader: Show error description when failing to load posts
crazytonyli Nov 25, 2025
55fb233
Fix unit tests
crazytonyli Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/KeystoneTests/Tests/Reader/ReaderDetailCoordinatorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ private class ReaderDetailViewMock: UIViewController, ReaderDetailView {
didCallShowError = true
}

func showErrorWithWebAction() {
func showErrorWithWebAction(error: String?) {
didCallShowErrorWithWebAction = true
}

Expand Down
4 changes: 2 additions & 2 deletions WordPress/Classes/ViewRelated/Reader/Detail/ReaderDetailCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ class ReaderDetailCoordinator {
self?.post = post
self?.renderPostAndBumpStats()
}, failure: { [weak self] error in
self?.postURL == nil ? self?.showError(error: error) : self?.view?.showErrorWithWebAction()
self?.postURL == nil ? self?.showError(error: error) : self?.view?.showErrorWithWebAction(error: error?.localizedDescription)
self?.reportPostLoadFailure()
})
}
Expand All @@ -363,7 +363,7 @@ class ReaderDetailCoordinator {
self?.renderPostAndBumpStats()
}, failure: { [weak self] error in
DDLogError("Error fetching post for detail: \(String(describing: error?.localizedDescription))")
self?.postURL == nil ? self?.showError(error: error) : self?.view?.showErrorWithWebAction()
self?.postURL == nil ? self?.showError(error: error) : self?.view?.showErrorWithWebAction(error: error?.localizedDescription)
self?.reportPostLoadFailure()
})
}
Expand Down
9 changes: 5 additions & 4 deletions WordPress/Classes/ViewRelated/Reader/Detail/ReaderDetailViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ protocol ReaderDetailView: AnyObject {
func renderRelatedPosts(_ posts: [RemoteReaderSimplePost])
func showLoading()
func showError(subtitle: String?)
func showErrorWithWebAction()
func showErrorWithWebAction(error: String?)
func scroll(to: String)
func updateHeader()
func updateLikesView(with viewModel: ReaderDetailLikesViewModel)
Expand Down Expand Up @@ -399,8 +399,8 @@ class ReaderDetailViewController: UIViewController, ReaderDetailView {
}

/// Shown an error with a button to open the post on the browser
func showErrorWithWebAction() {
displayLoadingViewWithWebAction(title: LoadingText.errorLoadingTitle)
func showErrorWithWebAction(error: String?) {
displayLoadingViewWithWebAction(title: LoadingText.errorLoadingTitle, subtitle: error)
}

/// Scroll the content to a given #hash
Expand Down Expand Up @@ -1122,9 +1122,10 @@ private extension ReaderDetailViewController {
showLoadingView()
}

func displayLoadingViewWithWebAction(title: String, accessoryView: UIView? = nil) {
func displayLoadingViewWithWebAction(title: String, subtitle: String? = nil, accessoryView: UIView? = nil) {
noResultsViewController.configure(title: title,
buttonTitle: LoadingText.errorLoadingPostURLButtonTitle,
subtitle: subtitle,
accessoryView: accessoryView)
showLoadingView()
}
Expand Down