Fix an issue with Reader failing to parse some search results #25022
+225
−261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kean
changed the title
Collaborator
Generated by 🚫 Danger |
kean
commented
Nov 26, 2025
|
|
||
| // Fixes CMM-1002: in some cases, the backend fails to embed certain fields | ||
| // directly in the feed object | ||
| if feedURL == nil { |
Contributor
Author
There was a problem hiding this comment.
Not very elegant, but matches the rest of the code and gets the job done.
Both title and url fields are now optional. Hopefully, for each response, there will be a combination of at least some of these fields. The UI displays what's available.
| struct ReaderFeedEnvelope: Decodable { | ||
| let feeds: [ReaderFeed] | ||
| let total: Int | ||
| let total: Int? |
Contributor
Author
There was a problem hiding this comment.
This is not ideal, but it was another missing field. The service assumes that if total is nil, then there is no paging.
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 29949 | |
| Version | PR #25022 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 2c8a7c5 | |
| Installation URL | 0hmr21g5metjo |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 29949 | |
| Version | PR #25022 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 2c8a7c5 | |
| Installation URL | 0kidpd01thg0o |
crazytonyli
approved these changes
Nov 26, 2025
kean
force-pushed
the
task/improve-reader-search
branch
from
03ff902 to
1283911
Compare
|
jkmassel
pushed a commit
that referenced
this pull request
Nov 27, 2025
* Remove loading state title * More resilient Reader Search response parsing * Update release notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://linear.app/a8c/issue/CMM-1002/search-in-reader-app-fails-to-decode-some-responses (see ticket for RCA)
Before / After
I also made a small UI change to remove the title from the loading state to match the rest of the app.
Before / After
