Skip to content

Conversation

@crazytonyli
Copy link
Contributor

Description

The original() function will conflict with the original property once AbstractPost is translated to Swift. I renamed it to rootOriginal(). Any suggestions for alternative names are welcome!

@crazytonyli crazytonyli added this to the 26.6 milestone Dec 1, 2025
@crazytonyli crazytonyli requested review from jkmassel and kean December 1, 2025 20:31
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 1, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number30049
VersionPR #25041
Bundle IDcom.jetpack.alpha
Commit76f8bc8
Installation URL5ivvcuan1hs48
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Dec 1, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number30049
VersionPR #25041
Bundle IDorg.wordpress.alpha
Commit76f8bc8
Installation URL23ligljoi39j8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean
Copy link
Contributor

kean commented Dec 2, 2025

Any suggestions for alternative names are welcome!

What about getOriginal()?

I wish this method returned Self instead of AbstractPost.

@crazytonyli
Copy link
Contributor Author

@kean Renamed in ⬆️ commit.

@crazytonyli crazytonyli enabled auto-merge December 2, 2025 21:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2025

@crazytonyli crazytonyli added this pull request to the merge queue Dec 3, 2025
Merged via the queue into trunk with commit ee6e037 Dec 3, 2025
26 of 32 checks passed
@crazytonyli crazytonyli deleted the abstract-post-original-rename branch December 3, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants