Plans: plans list #4772
Merged
Plans: plans list #4772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the translation is too long, we don't want to crop the price
Removed by mistake in f5ca4e1
Also, implement Equatable so we can test if the decoded model is equal to the original.
Since I wanted `attributedTitle` to be private, I moved the creation to a helper so it can still be tested.
Merged
Contributor
|
The tableview separator inset looks to be much larger than in the latest mockup that I have. I think it should be the standard inset:
|
Contributor
|
I think this looks good, other than the comment above!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the plans list view introduced in #4747 to show the actual current plan, and match the style in the mockups.
It was also refactored to use ImmuTable, added view controller restoration, and unit tests.
Known issues
Blog.plancould be cleaner whenBloggets nullability annotations Extract Blog core data properties to an extension #4762Needs Review: @frosty