5245-Implement WordPress.com Rest API Using NSURLSession on MediaServiceRemoteRest #5327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on based classes.
…using_NSURLSession
…elation and progress report.
…ike NSURLSession doesn't use the same variable/pointer but only the same name.
…using_NSURLSession # Conflicts: # WordPress/Classes/Models/Blog.m # WordPress/Classes/Services/MediaService.m
WordPress/Classes/Models/Blog.h
Outdated
| @return a WordPressComRestApi object if available | ||
| */ | ||
| - (WordPressComRestApi *)comRestApi; |
Member
There was a problem hiding this comment.
For consistency with WPAccount, I'd call this wordPressComRestApi. Also, make sure to mark it _Nullabe once #5325 is merged.
…using_NSURLSession
Contributor
Author
|
@koke ready for another look. |
Member
|
I like the changes. Can you fix the merge conflicts before I do a final test? |
…using_NSURLSession # Conflicts: # WordPress/WordPress.xcodeproj/project.pbxproj
Contributor
Author
|
@koke ready for another round of review. |
…using_NSURLSession # Conflicts: # WordPress/Classes/ViewRelated/Me/GravatarPickerViewController.swift # WordPress/Classes/ViewRelated/Me/MeViewController.swift
| */ | ||
| @interface WPUserAgent : NSObject | ||
|
|
||
| + (instancetype)sharedInstance; |
Member
There was a problem hiding this comment.
Since WPUserAgent doesn't hold any state, why do you need a shared instance? Can't you just instantiate a new one when needed?
Contributor
Author
There was a problem hiding this comment.
You are right, I removed this out and just use a simple instance.
| userInfo[NSLocalizedDescriptionKey] = errorMessage; | ||
| newError = [[NSError alloc] initWithDomain:WordPressComApiErrorDomain code:errorCode userInfo:userInfo]; | ||
| } else if ([error.domain isEqualToString:WordPressComRestApiErrorDomain]) { | ||
|
|
Member
|
Looks good, |
SergioEstevao
deleted the
issue/5245_Implement_WordPressComRESTAPI_using_NSURLSession
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #5245
This is the first step to implementing our Network layer using NSURLSession stack.
In this PR I implemented a first version of the WP.com REST API object using the AFNetworking class that use NSURLSession.
One of the main design decisions was to hide away the implementations details on how the Network layer is implemented in a way that we can later switch to another solution if we want to.
This PR only changed the MediaServiceRest to use the new API object other PRs will follow that will change the other services one by one.
To test:
Needs review: @koke