Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@oguzkocer
Copy link
Contributor

@oguzkocer oguzkocer commented Dec 2, 2022

#711 does not contain any release notes, so I wasn't sure how to handle the CHANGELOG file. I could either:

  • Create a 4.3.0 without any release notes
  • Don't have any 4.3.0 entry at all

I thought not having the entry made more sense, although neither feels right. I am happy to follow a different approach next time if reviewers have any suggestions. For this time, I have very limited time today to finish the WooCommerce-iOS code freeze and I didn't want this to be the blocker. We can even fix the issue after the fact, it just won't be part of 4.3.0 tag.

Update

I had to update the commit to include the Podfile.lock change.

I ran bundle exec pod install before opening this PR, but the Podfile.lock didn't get updated. I guess I missed something. Sorry about that!

@oguzkocer oguzkocer requested a review from a team December 2, 2022 18:10
@oguzkocer oguzkocer enabled auto-merge December 2, 2022 18:10
@crazytonyli
Copy link
Contributor

@oguzkocer
Copy link
Contributor Author

@crazytonyli I've mentioned the situation with the CHANGELOG file in the PR description. Did you miss that by any chance?

@crazytonyli
Copy link
Contributor

No, I saw that. But I noticed there is a 4.3.0 tag, which I think probably unblocked your WCiOS code freeze? And presumed you probably have time to update the CHANGELOG.

@oguzkocer oguzkocer merged commit 2ac42af into trunk Dec 5, 2022
@oguzkocer oguzkocer deleted the release/4.3.0 branch December 5, 2022 04:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants