This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Add search param in getWPThemesPage method and migrate endpoint to v2.0
#834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Generated by 🚫 Danger |
- Delete `ThemeRequestFilterKey` constant in ThemeServiceRemote.m - Remove `search` parameter assertion in `getThemesForBlogId` method - Eliminate filter parameter from `getThemesForBlogId` API call
…te, `getWPThemesPage` with search method
pmusolino
changed the title
getWPThemesPage methodgetWPThemesPage method and migrate endpoint to v2.0
Contributor
|
LGTM – the changes to the package file look good. I will approve it once there is a respective PR in WordPress-iOS with these changes where they could be tested. |
Merged
14 tasks
Contributor
Author
|
Opened the respective PR in WordPress-iOS repo wordpress-mobile/WordPress-iOS#24262 |
kean
approved these changes
Mar 21, 2025
Contributor
kean
left a comment
kean
left a comment
There was a problem hiding this comment.
This looks good. Please feel free to incorporating it in wpios-edition, but make sure to pull the changes first so your binary have all changes from both wpios-edition and your branch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR can be tested through wordpress-mobile/WordPress-iOS#24262
WordPressKit.zip
This is part of the work needed to fix this issue: wordpress-mobile/WordPress-iOS#23153
In WPiOS, the theme search was not functioning correctly because the search was conducted locally. As a result, since it also supports pagination, the search only considered the elements that had been fetched. If some elements were beyond the already downloaded data, they were not displayed.
In this PR, I migrated the endpoint
rest/v1.2/themesto v2.0, as v1.2 has been deprecated. I also introduced thesearchparameter, which allows users to search for themes by keyword. Please refer to the linear issue for more detailsCMM-55/cannot-find-seedlet-theme.CHANGELOG.mdif necessary.