Skip to content
This repository was archived by the owner on Sep 15, 2025. It is now read-only.

Conversation

@crazytonyli
Copy link
Contributor

@crazytonyli crazytonyli commented Jul 30, 2025

Description

The URLSession.perform() async function in HTTPClient currently only supports cancellation via Progress, but does not support cancelling via its running Task. This PR adds that missing support.

The changes are pretty minimal. It's easier to review by hiding whitespace in the diff.

WordPressKit.zip

Testing Details

See the new unit test.


  • Please check here if your pull request includes additional test coverage.
  • I have considered if this change warrants release notes and have added them to the appropriate section in the CHANGELOG.md if necessary.

@crazytonyli crazytonyli requested a review from kean July 30, 2025 01:55
@crazytonyli crazytonyli enabled auto-merge July 30, 2025 01:56
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).

Generated by 🚫 Danger

@kean
Copy link
Contributor

kean commented Jul 31, 2025

The changes are pretty minimal. It's easier to review by hiding whitespace in the diff.

Nice tip. I didn't know that.

@crazytonyli crazytonyli merged commit 2b7d4f6 into trunk Jul 31, 2025
7 checks passed
@crazytonyli crazytonyli deleted the cancel-task branch July 31, 2025 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants