This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Support Task cancellation #844
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
URLSession.perform()async function in HTTPClient currently only supports cancellation viaProgress, but does not support cancelling via its running Task. This PR adds that missing support.The changes are pretty minimal. It's easier to review by hiding whitespace in the diff.
WordPressKit.zip
Testing Details
See the new unit test.
CHANGELOG.mdif necessary.