This repository was archived by the owner on Sep 15, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Change Swift package to provide source code #846
Closed
Closed
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
0fa20af
Reorgnize files
crazytonyli 6c469a1
Delete Info.plist
crazytonyli 666dff0
Replace `#import <WordPressKit/*.h>` statements
crazytonyli ddc54d5
Remove WPKit-Swift.h
crazytonyli 6b696bc
Translate RemoteUser to Swift
crazytonyli 19585fb
Rearrange files
crazytonyli c8b0bb0
Fix imports
crazytonyli ba19dee
Remove _implementationOnly imports
crazytonyli 3133cba
Minor syntactical changes
crazytonyli 388b86c
Remove WordPressKit.h
crazytonyli e93e791
Translate PostServiceRemoteREST.getLikesForPostID to Swift
crazytonyli abaf0ec
Add Package.swift
crazytonyli 6a8e615
Convert the Objective-C protocol to a Swift concrete type
crazytonyli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import Foundation | ||
|
|
||
| @objcMembers public class RemoteUser: NSObject { | ||
| public var userID: NSNumber? | ||
| public var username: String? | ||
| public var email: String? | ||
| public var displayName: String? | ||
| public var primaryBlogID: NSNumber? | ||
| public var avatarURL: String? | ||
| public var dateCreated: Date? | ||
| public var emailVerified: Bool = false | ||
| public var linkedUserID: NSNumber? | ||
| } | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The original properties in the original Objective-C code are
null_unspecifiedor implicitly unwrapped optional. I can keep the original code and make the new properties IUO, too. But that does not feel right.The new code now uses optional, which means the app will need to update their codebase to deal with the new optional properties instead of IUO properties.