Merged
Conversation
Contributor
moufmouf
commented
Feb 5, 2026
moufmouf
commented
- Moving duplicated HTML code in Mustache partials
- Adding a "Publish now" button right on the first page and another "Configure publishing" button
- Moving the module to ESM
- Fixing path in self-hosted single-domain mode
- Moving duplicated HTML code in Mustache partials - Adding a "Publish now" button right on the first page and another "Configure publishing" button - Moving the module to ESM - Fixing path in self-hosted single-domain mode
There was a problem hiding this comment.
Pull request overview
This PR refactors the codebase to improve maintainability and add new publishing features. The main changes include migrating to ESM modules, extracting duplicated HTML into Mustache partials, and adding a "Publish now" button on the index page.
Changes:
- Migrated the module system from CommonJS to ESM, updating vite.config.ts and package.json accordingly
- Refactored HTML templates to use Mustache partials (head, header, footer, error-popup) to eliminate code duplication
- Added a "Publish now" button to the index page with conditional enabling based on publishing configuration
- Removed the
/uploader/statusendpoint and moved its logic to FrontController methods - Fixed URL construction logic for self-hosted single-domain mode in the map display script
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Updated to output ESM format, removed redundant output.exports configuration |
| package.json | Added "type": "module" and removed CommonJS exports |
| src/server.ts | Commented out controller logging statements |
| src/controllers/UploaderController.ts | Removed /status endpoint (functionality moved to FrontController) |
| src/controllers/FrontController.ts | Added methods for loading partials, head scripts, secret config, and determining publishing status |
| public/styles/styles.css | Added styles for button groups, disabled buttons, error popups, and loading overlays |
| public/assets/views/*.html | Converted all templates to use Mustache partials, eliminating duplication |
| public/assets/views/partials/*.html | New partial templates for head, header, footer, and error popup |
| public/assets/views/partials/head-scripts/*.html | Extracted page-specific scripts into separate files |
| public/assets/js/index.js | Added setupPublishingActions function for "Publish now" button |
| .github/workflows/typecheck.yml | Added new GitHub Actions workflow for TypeScript type checking |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
moufmouf
force-pushed
the
refactor-code
branch
from
dc0a85e to
694bdba
Compare
|
🎉 This PR is included in version 1.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.