Skip to content

feat: stream the stdout using spawn() and show the next start time - #5

Draft
jizusun wants to merge 11 commits into
workadventure:mainfrom
jizusun:main
Draft

feat: stream the stdout using spawn() and show the next start time#5
jizusun wants to merge 11 commits into
workadventure:mainfrom
jizusun:main

Conversation

@jizusun

@jizusun jizusun commented Jul 31, 2024

Copy link
Copy Markdown
  • use spawn() instead of exec() to stream the stdout/stderr
  • add the package tzdata so that the TZ is recognized
  • push to ghcr.io
  • update the description of the Docker Hub page
  • push image as latest instead of main (close The docker image tag latest is not pushed #4 )
  • add last-success folder to keep the report

Improved logging

image

Improved UI

image

@jizusun jizusun changed the title feat: stream the stdout using spawn() feat: stream the stdout using spawn() and show the next start time Jul 31, 2024
@jizusun

jizusun commented Aug 7, 2024

Copy link
Copy Markdown
Author

@moufmouf Guess you're on vacation recently 😄
Will you take a look at this PR when you're back?

@moufmouf

moufmouf commented Aug 8, 2024

Copy link
Copy Markdown
Contributor

Woah!

This is awesome. I only recently started the project and did not expect a PR so fast on it.

Thanks a lot. Everything looks great to me. I just have one question: I'm not familiar with the ".devcontainer" directory.
What is it used for and how do you use it?

I guess you are using it to set up and work with the environment. If so, would you mind adding a small "Contributing" section in the README explaining your workflow to set up a dev environment with this devcontainer thing?

@jizusun

jizusun commented Aug 12, 2024

Copy link
Copy Markdown
Author

Woah!

This is awesome. I only recently started the project and did not expect a PR so fast on it.

Thanks a lot. Everything looks great to me. I just have one question: I'm not familiar with the ".devcontainer" directory. What is it used for and how do you use it?

I guess you are using it to set up and work with the environment. If so, would you mind adding a small "Contributing" section in the README explaining your workflow to set up a dev environment with this devcontainer thing?

Thank you so much for your acknowledgement!
You're right! Let me make it draft and add a little bit more about contributing and then request review from you!

@jizusun
jizusun marked this pull request as draft August 12, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The docker image tag latest is not pushed

2 participants