Open
Conversation
Codecov Report
@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage 55.17% 55.17%
=======================================
Files 1 1
Lines 29 29
Branches 5 5
=======================================
Hits 16 16
Misses 13 13 Continue to review full report at Codecov.
|
moufmouf
reviewed
Oct 28, 2021
moufmouf
requested changes
Oct 28, 2021
added 5 commits
November 5, 2021 15:15
moufmouf
reviewed
Dec 13, 2021
d04a7e4 to
1ff439b
Compare
f66b844 to
54d554c
Compare
df67283 to
7181ae9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/!\ WIP /!\
Adds the logo upload feature, which is basically another field type in the config panel that deals with the preview and the replacement of the old logo URL defined in a Tiled variable by a new one, uploaded by the user.
I called this 'logo' replacement but this could be really any image in Tiled.
You can test this with the map: 'configuration_logo.json'
TODO:
PS: This is working with a local upload (uploading locally the image in the disk and retrieving the path, then replacing the image)