feat: add preferred codec support and real browser verification#18
Merged
feat: add preferred codec support and real browser verification#18
Conversation
Add preferred codec selection for media tracks via RTCRtpTransceiver setCodecPreferences, keeping lite options separate from full options and documenting the new option in the README. Introduce a browser codec test that negotiates real media streams between peers and verifies VP9 via getStats, with Safari/WebKit skipped to avoid Playwright capability mismatches. Update Playwright launch settings to enable fake camera devices on Chromium and Firefox so the test uses getUserMedia instead of canvas streams.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b2228d33f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add preferred codec selection for media tracks when constructing the
Peerobject.New option:
preferredCodecs- prefer codecs for outbound tracks (by kind), usingRTCRtpTransceiver.setCodecPreferenceswhere supported. Example:{ video: ['video/AV1', 'video/VP9', 'video/VP8'], audio: ['audio/opus'] }. If the browser does not support codec preferences (or the codec is not supported), it falls back to the browser’s default.Introduce a browser codec test that negotiates real media streams between peers and verifies VP9 via getStats, with Safari/WebKit skipped to avoid Playwright capability mismatches. Update Playwright launch settings to enable fake camera devices on Chromium and Firefox so the test uses getUserMedia instead of canvas streams.