fix: updating "write" signature to accept same types as "send"#9
Merged
fix: updating "write" signature to accept same types as "send"#9
Conversation
write now accepts ArrayBufferView | ArrayBuffer | Uint8Array | string | Blob
…ended yet, similar to the previous _final implementation. Consider adding if (!this._readableEnded) this.push(null) before emitting 'finish' to maintain the behavior of closing both sides of the connection when end() is called. This is important because the comment at line 591-592 states "Half open connections are not supported."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write now accepts ArrayBufferView | ArrayBuffer | Uint8Array | string | Blob