Skip to content

Fix selector injection and close() race condition in browser package - #224

Merged
sroussey merged 3 commits into
browserfrom
copilot/sub-pr-223
Feb 22, 2026
Merged

Fix selector injection and close() race condition in browser package#224
sroussey merged 3 commits into
browserfrom
copilot/sub-pr-223

Conversation

Copilot AI commented Feb 21, 2026

Copy link
Copy Markdown
Contributor
  • Fix selector injection vulnerability in A11yParser.ts
  • Fix race condition in PlaywrightContext.ts close() method
  • Investigate CI build failures - 12 Playwright integration tests failing in base browser branch and all subsequent runs
  • Fix CI: add bunx playwright install chromium --with-deps step to test.yml so Playwright browser binaries are available during bun test

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…Context close()

Co-authored-by: sroussey <127349+sroussey@users.noreply.github.com>
Copilot AI changed the title [WIP] Add initial version of @workglow/browser package for automation Fix selector injection and close() race condition in browser package Feb 21, 2026
Copilot AI requested a review from sroussey February 21, 2026 19:28
@sroussey
sroussey marked this pull request as ready for review February 21, 2026 22:37
@sroussey

Copy link
Copy Markdown
Collaborator

@copilot fix build/test issues

Co-authored-by: sroussey <127349+sroussey@users.noreply.github.com>

Copilot AI commented Feb 21, 2026

Copy link
Copy Markdown
Contributor Author

@copilot fix build/test issues

Fixed in commit 15a0c75. The 12 Playwright integration tests were failing because the CI workflow installed the playwright npm package via bun i but never downloaded the actual Chromium browser binary. Added bunx playwright install chromium --with-deps to .github/workflows/test.yml after the bun i step. The remaining 1 failure (TextEmbeddingTask > HuggingFace Transformers > gte-small) is a flaky network/download test that was already inconsistent in the browser base branch (failed in one run, passed in another).

@sroussey
sroussey merged commit 7989c48 into browser Feb 22, 2026
1 of 3 checks passed
@sroussey
sroussey deleted the copilot/sub-pr-223 branch February 25, 2026 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants