Fix CI playwright install, selector injection in A11yParser, and close() race condition - #225
Merged
Merged
Conversation
Co-authored-by: sroussey <127349+sroussey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add @workglow/browser package for browser automation
Fix CI playwright install, selector injection in A11yParser, and close() race condition
Feb 22, 2026
sroussey
marked this pull request as ready for review
February 22, 2026 02:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playwright Integration tests were failing in CI due to missing browser binary, plus two code-quality issues flagged in review.
Changes
CI (
test.yml): Addbunx playwright install chromium --with-depsbefore running tests — was the root cause of all 12 Playwright/Workflow Integration test failures.A11yParser.ts: Replacedocument.querySelector(\label[for="${id}"]`)withgetElementsByTagName+htmlFor` property comparison to eliminate CSS selector injection risk from unsanitized element IDs.PlaywrightContext.ts: Fixclose()so references are cleared before the async close races the timeout — capturingcontextReflocally prevents any code path from operating on a null/freed context while a close is still in-flight.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.