Fix flaky Form 1-Z history test due to filesystem ordering and empty summaryInfoOffering - #59
Merged
Merged
Conversation
Merged
…InfoOffering Co-authored-by: sroussey <127349+sroussey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing test in crowdfund
Fix flaky Form 1-Z history test due to filesystem ordering and empty summaryInfoOffering
Feb 28, 2026
sroussey
marked this pull request as ready for review
February 28, 2026 18:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
should store offering summaries as historywas non-deterministically failing becausereaddirSyncreturns files in filesystem order (not alphabetical), and the first file encountered withsummaryInfoOfferingcontained a self-closing XML tag<summaryInfoOffering/>, which xml2js parses as[""].The old condition
summaryInfoOffering.length > 0matched this (length=1), butprocessOfferingSummariescorrectly skips non-object entries — so nothing was saved andhistories.lengthwas always 0.Fix
Changed the test guard condition to check for actual object entries:
This skips files where
summaryInfoOfferingcontains only empty/self-closing XML entries and advances to a file with real summary data.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.