chore: Update dependencies#414
Merged
Patrick Lafrance (patricklafrance) merged 2 commits intoApr 1, 2026
Merged
Conversation
- Remove deprecated moduleResolution "Node" (node10) from browserslist-config and stylelint-configs - Add explicit "types" for node and jest where needed (TS6 no longer auto-discovers @types) - Add ignoreDeprecations for tsup-lib (tsup internally sets deprecated baseUrl) - Update @typescript/native-preview, turbo, and other dependencies Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot started reviewing on behalf of
Patrick Lafrance (patricklafrance)
April 1, 2026 02:09
View session
@workleap/browserslist-config
@workleap/eslint-configs
@workleap/postcss-configs
@workleap/rsbuild-configs
@workleap/rslib-configs
@workleap/stylelint-configs
@workleap/swc-configs
@workleap/tsup-configs
@workleap/typescript-configs
@workleap/webpack-configs
commit: |
Patrick Lafrance (patricklafrance)
merged commit 1113edf
into
main
9 of 10 checks passed
Patrick Lafrance (patricklafrance)
deleted the
chore/update-dependencies-566765
branch
Merged
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the workspace’s toolchain dependencies (notably TypeScript native preview, Turbo, and Vite-related packages) and adjusts TypeScript project settings across packages/samples to keep builds/typechecking working with newer versions.
Changes:
- Bump
@typescript/native-previewacross the workspace and refresh thepnpm-lock.yaml. - Update select tooling dependencies (e.g.,
turbo,@vitejs/plugin-react,netlify-cli) used by samples and configs packages. - Standardize TS configs by adding explicit
compilerOptions.types(mostlynode) and normalizingrootDirpaths in build tsconfigs.
Reviewed changes
Copilot reviewed 45 out of 47 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Adds explicit Node typings at the repo root. |
| package.json | Bumps @typescript/native-preview and turbo. |
| pnpm-lock.yaml | Lockfile refresh reflecting dependency upgrades (Turbo/Vite/plugin-react/etc.). |
| .changeset/fast-cooks-hide.md | Publishes patch bumps for multiple config packages due to dependency/tooling updates. |
| samples/webpack/tsup-lib/tsconfig.json | Adds Node types and documents ignoreDeprecations. |
| samples/webpack/tsup-lib/package.json | Bumps @typescript/native-preview. |
| samples/webpack/components/tsconfig.json | Adds Node + Jest types for TS. |
| samples/webpack/components/package.json | Bumps @typescript/native-preview. |
| samples/webpack/app/tsconfig.json | Adds Node + Jest types for TS. |
| samples/webpack/app/package.json | Bumps @typescript/native-preview. |
| samples/storybook/rslib/tsconfig.json | Adds Node types for TS. |
| samples/storybook/rslib/package.json | Bumps @typescript/native-preview. |
| samples/storybook/rsbuild/tsconfig.json | Adds Node types for TS. |
| samples/storybook/rsbuild/package.json | Bumps @typescript/native-preview. |
| samples/rsbuild/rslib-lib/tsconfig.json | Adds Node types for TS. |
| samples/rsbuild/rslib-lib/tsconfig.build.json | Normalizes rootDir to src. |
| samples/rsbuild/rslib-lib/package.json | Bumps @typescript/native-preview. |
| samples/rsbuild/components/tsconfig.json | Adds Node types for TS. |
| samples/rsbuild/components/package.json | Bumps @typescript/native-preview and @vitejs/plugin-react. |
| samples/rsbuild/app/tsconfig.json | Adds Node types for TS. |
| samples/rsbuild/app/package.json | Bumps @typescript/native-preview, @vitejs/plugin-react, and netlify-cli. |
| packages/webpack-configs/tsconfig.json | Adds Node types for TS. |
| packages/webpack-configs/package.json | Bumps @typescript/native-preview. |
| packages/tsup-configs/tsconfig.json | Adds Node types for TS. |
| packages/tsup-configs/tsconfig.build.json | Normalizes rootDir to src. |
| packages/tsup-configs/package.json | Bumps @typescript/native-preview. |
| packages/swc-configs/tsconfig.json | Adds Node types for TS. |
| packages/swc-configs/tsconfig.build.json | Normalizes rootDir to src. |
| packages/swc-configs/package.json | Bumps @typescript/native-preview. |
| packages/stylelint-configs/tsconfig.json | Replaces module settings with Node types (see PR comments re: CJS export =). |
| packages/stylelint-configs/tsconfig.build.json | Normalizes rootDir to src. |
| packages/stylelint-configs/package.json | Bumps @typescript/native-preview. |
| packages/rslib-configs/tsconfig.json | Adds Node types for TS. |
| packages/rslib-configs/tsconfig.build.json | Normalizes rootDir to src. |
| packages/rslib-configs/package.json | Bumps @typescript/native-preview. |
| packages/rsbuild-configs/tsconfig.json | Adds Node types for TS. |
| packages/rsbuild-configs/tsconfig.build.json | Normalizes rootDir to src. |
| packages/rsbuild-configs/package.json | Bumps @typescript/native-preview. |
| packages/postcss-configs/tsconfig.json | Adds Node types for TS. |
| packages/postcss-configs/tsconfig.build.json | Normalizes rootDir to src. |
| packages/postcss-configs/package.json | Bumps @typescript/native-preview. |
| packages/eslint-configs/tsconfig.json | Adds Node types for TS. |
| packages/eslint-configs/tsconfig.build.json | Normalizes rootDir to src. |
| packages/eslint-configs/package.json | Bumps @typescript/native-preview. |
| packages/browserslist-config/tsconfig.json | Replaces module settings with Node types (see PR comments re: CJS export =). |
| packages/browserslist-config/tsconfig.build.json | Normalizes rootDir to src. |
| packages/browserslist-config/package.json | Bumps @typescript/native-preview. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -3,8 +3,7 @@ | |||
| "compilerOptions": { | |||
| "incremental": true, | |||
| "tsBuildInfoFile": "node_modules/.cache/tsbuildinfo.json", | |||
There was a problem hiding this comment.
packages/stylelint-configs/src/index.ts uses export = ..., which requires a CommonJS module target for correct typechecking/IDE validation. This tsconfig now inherits module/moduleResolution from @workleap/typescript-configs (NodeNext), which is likely to produce diagnostics like “export assignment is not allowed in ECMAScript modules” and diverges from tsconfig.build.json (CommonJS). Consider re-adding compilerOptions.module and compilerOptions.moduleResolution here (or switching the source to ESM exports if the package is moving to ESM).
Suggested change
| "tsBuildInfoFile": "node_modules/.cache/tsbuildinfo.json", | |
| "tsBuildInfoFile": "node_modules/.cache/tsbuildinfo.json", | |
| "module": "CommonJS", | |
| "moduleResolution": "node", |
| @@ -3,8 +3,7 @@ | |||
| "compilerOptions": { | |||
| "incremental": true, | |||
| "tsBuildInfoFile": "node_modules/.cache/tsbuildinfo.json", | |||
There was a problem hiding this comment.
packages/browserslist-config/src/index.ts uses export = ..., which is a CommonJS-style export. This tsconfig now inherits module/moduleResolution from @workleap/typescript-configs (NodeNext), which can break typechecking/IDE diagnostics and diverges from tsconfig.build.json (CommonJS). Re-add compilerOptions.module and compilerOptions.moduleResolution here (or update the source to ESM exports if intentional).
Suggested change
| "tsBuildInfoFile": "node_modules/.cache/tsbuildinfo.json", | |
| "tsBuildInfoFile": "node_modules/.cache/tsbuildinfo.json", | |
| "module": "CommonJS", | |
| "moduleResolution": "Node", |
Comment on lines
+4
to
6
| // Required because tsup internally sets "baseUrl" during DTS generation, which is deprecated in TypeScript 7.0. | ||
| "ignoreDeprecations": "6.0", | ||
| "incremental": true, |
There was a problem hiding this comment.
The comment says the deprecation comes from TypeScript 7.0, but ignoreDeprecations is set to "6.0". Either adjust the comment to match the ignored deprecation version, or bump ignoreDeprecations to the version that actually introduced the warning so this remains accurate as dependencies change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.