feat: add Node types by default to TypeScript configs#427
Merged
Patrick Lafrance (patricklafrance) merged 1 commit intoMay 12, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Patrick Lafrance (patricklafrance)
May 12, 2026 16:13
View session
@workleap/browserslist-config
@workleap/eslint-configs
@workleap/postcss-configs
@workleap/rsbuild-configs
@workleap/rslib-configs
@workleap/stylelint-configs
@workleap/swc-configs
@workleap/tsup-configs
@workleap/typescript-configs
@workleap/webpack-configs
commit: |
Patrick Lafrance (patricklafrance)
deleted the
feat/add-node-types-to-ts-configs
branch
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the shared @workleap/typescript-configs base tsconfig to include Node.js type definitions by default, and adds a changeset to publish the update.
Changes:
- Added
compilerOptions.types: ["node"]to the sharedcore.jsontsconfig. - Added a changeset to release
@workleap/typescript-configswith this update.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/typescript-configs/core.json | Adds Node type definitions to the base TypeScript config used by all exported configs. |
| .changeset/funky-otters-retire.md | Declares a patch release describing the Node types default change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "module": "NodeNext", | ||
| "target": "ESNext", | ||
| "lib": ["ESNext", "DOM"], | ||
| "types": ["node"], |
Comment on lines
+2
to
+5
| "@workleap/typescript-configs": patch | ||
| --- | ||
|
|
||
| Adding Node types by default to TypeScript configs. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.