Skip to content

Mark user_agent field as deprecated in LabelerInput proto. #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wliue merged 1 commit into from
Nov 7, 2024
Merged

Mark user_agent field as deprecated in LabelerInput proto. #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/main/proto/wfa/virtual_people/common/event.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,8 @@ message LabelerInput {
// Required. When this event occurs in microseconds since epoch.
optional int64 timestamp_usec = 2;

// TODO(@wliue): Deprecate user_agent when all usages are migrated.
// User agent string. Labeler uses this to compute device type.
optional string user_agent = 3;
optional string user_agent = 3 [deprecated = true];

// Geo data.
optional GeoLocation geo = 4;
Expand Down
Loading