-
Notifications
You must be signed in to change notification settings - Fork 0
Integration Test for Model Compiler Main #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
tcsnfkx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 4 unresolved discussions (waiting on @EvgSkv, @wastadtlander, and @wliue)
src/test/cc/wfa/virtual_people/training/model_compiler/compiler_main_test.cc line 30 at r1 (raw file):
namespace { void ReadTextProtoFile(std::string path, google::protobuf::Message& message) {
Can we use absl::string_view?
Code quote:
std::stringsrc/test/cc/wfa/virtual_people/training/model_compiler/compiler_main_test.cc line 39 at r1 (raw file):
} bool ProtoEquals(std::string expectedPath, std::string outputPath) {
Same as above.
src/test/cc/wfa/virtual_people/training/model_compiler/compiler_main_test.cc line 39 at r1 (raw file):
} bool ProtoEquals(std::string expectedPath, std::string outputPath) {
Could you please change to "expected_path"?
Code quote:
expectedPathsrc/test/cc/wfa/virtual_people/training/model_compiler/compiler_main_test.cc line 39 at r1 (raw file):
} bool ProtoEquals(std::string expectedPath, std::string outputPath) {
Same as above.
Code quote:
outputPath
tcsnfkx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @EvgSkv, @wastadtlander, and @wliue)
tcsnfkx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @EvgSkv, @wastadtlander, and @wliue)
Implemented the following:
This change is