Draft
Conversation
for more information, see https://pre-commit.ci
This reverts commit 2eb4db3.
This reverts commit 9f660ff.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Contributor
Author
|
The new example I've tried to add to test/verify this functionality is at "notebooks/Tutorials/Degurba_Example.ipynb" on the feature branch associated with this pull request. Any help/thoughts/guidance on this function is appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build this PR off of #26 (so the long list of commits will go away once that's merged).
Trying to create an example notebook to help answer #6. Started with the existing "Implementation" notebook, URB_DECAT_B_ExploringGHSSMODcode.ipynb and tried to create a reproducible example.
The new example notebook uses
poochto fetch and cache the data used for the notebook in an effort to avoid adding more "sample data" to the repository. It wasn't clear to me where the existing notebook's data came from, so I tried to find similar data and setuppoochto retrieve that.Unfortunately, for me the notebook hangs on the
calculateDegurba()method call; @bpstewar or @andresfchamorro if either of you have any intuition as to why this might be the case I'm all ears.I'm not 100% sure I'm pulling the right raster data to begin with, so knowing if the data I've set the notebook to grab is correct would be a good start. From there I'm not sure if it is getting stuck because it's trying to operate over a large raster and my computer has limited memory or what. Any help is appreciated, thanks!