Skip to content

chore: add localstack token#195

Merged
paolodamico merged 6 commits into
mainfrom
localstack-token
Mar 27, 2026
Merged

chore: add localstack token#195
paolodamico merged 6 commits into
mainfrom
localstack-token

Conversation

@paolodamico

@paolodamico paolodamico commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

Note

Medium Risk
Moderate risk due to Rust toolchain and AWS SDK dependency upgrades that could subtly change build behavior or AWS client/runtime semantics; CI changes mainly affect test environment startup timing and LocalStack authentication.

Overview
Updates CI and Docker Compose to support authenticated LocalStack by wiring LOCALSTACK_AUTH_TOKEN into the LocalStack container and GitHub Actions jobs, and increases the LocalStack startup wait with log output to reduce flaky runs.

Bumps the Rust toolchain/base builder image to 1.92 and upgrades AWS SDK crates (plus related lockfile updates), and adds a cargo-deny advisory ignore for RUSTSEC-2026-0049 affecting rustls-webpki.

Written by Cursor Bugbot for commit e1b16ec. This will update automatically on new commits. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: LocalStack auth token not passed to Docker container
    • Added LOCALSTACK_AUTH_TOKEN to docker-compose.yml environment section to pass the token from host to container.

Create PR

Or push these changes by commenting:

@cursor push 2bc8097729
Preview (2bc8097729)
diff --git a/docker-compose.yml b/docker-compose.yml
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -11,6 +11,7 @@
     environment:
       - SERVICES=s3,kms,dynamodb
       - DISABLE_EVENTS=1
+      - LOCALSTACK_AUTH_TOKEN
     volumes:
       - /var/lib/localstack
       - /var/run/docker.sock:/var/run/docker.sock

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Comment thread .github/workflows/ci.yml

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ebf6d4eaa1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/ci.yml

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment thread docker-compose.yml Outdated
Comment thread docker-compose.yml Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates local development and CI to support authenticated LocalStack usage, while also bumping the Rust toolchain and AWS SDK crate versions.

Changes:

  • Wire LOCALSTACK_AUTH_TOKEN into docker-compose and GitHub Actions jobs that start LocalStack.
  • Adjust CI LocalStack startup behavior (increased wait + log output) to reduce flaky runs.
  • Bump Rust toolchain/base builder image and upgrade AWS SDK crates; add a cargo-deny advisory ignore for RUSTSEC-2026-0049.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
rust-toolchain.toml Updates the pinned Rust toolchain version.
Dockerfile Bumps the Rust builder base image version.
docker-compose.yml Passes LOCALSTACK_AUTH_TOKEN into the LocalStack container environment.
.github/workflows/ci.yml Provides LOCALSTACK_AUTH_TOKEN to CI LocalStack startup and tweaks startup timing/logging.
Cargo.toml Updates AWS SDK crate versions.
Cargo.lock Lockfile updates from dependency bumps.
deny.toml Adds a cargo-deny ignore entry for RUSTSEC-2026-0049.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
Comment thread rust-toolchain.toml
@@ -1,5 +1,5 @@
[toolchain]
channel = "1.91.0"
channel = "1.92"

Copilot AI Mar 26, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rust-toolchain.toml previously pinned a full patch release (e.g. 1.91.0), but is now set to "1.92". This can float to newer patch releases over time and diverge from the Docker builder image (rust:1.92.0-slim), making local/CI/container builds less reproducible. Consider pinning to the full patch version (e.g. 1.92.0) or aligning both files to the same policy (both pinned or both floating).

Suggested change
channel = "1.92"
channel = "1.92.0"

Copilot uses AI. Check for mistakes.
Comment thread deny.toml
Comment thread .github/workflows/ci.yml
@paolodamico paolodamico merged commit 290a4b4 into main Mar 27, 2026
16 checks passed
@paolodamico paolodamico deleted the localstack-token branch March 27, 2026 17:56
@github-actions github-actions Bot mentioned this pull request May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants