Skip to content

chore: update dockerfile#53

Merged
0xOsiris merged 1 commit into
mainfrom
osiris/add-curl
May 13, 2026
Merged

chore: update dockerfile#53
0xOsiris merged 1 commit into
mainfrom
osiris/add-curl

Conversation

@0xOsiris

@0xOsiris 0xOsiris commented May 13, 2026

Copy link
Copy Markdown
Contributor

Note

Low Risk
Low risk Docker build change; it only affects image dependencies and should mainly impact build reproducibility and runtime tooling availability.

Overview
Improves Docker image reliability by installing sccache with --locked to ensure Cargo.lock is respected during builds.

Updates the runtime Debian image to also install curl alongside existing packages.

Reviewed by Cursor Bugbot for commit 9ab8e33. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 9ab8e33. Configure here.

Comment thread Dockerfile
FROM rust:1.85.1 AS base

RUN cargo install sccache --version ^0.9
RUN cargo install sccache --version ^0.9 --locked

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing --locked flag on cargo-chef install

Low Severity

The --locked flag was added to cargo install sccache but not to the adjacent cargo install cargo-chef command. Both tools are installed the same way, so the inconsistency looks like an oversight. Without --locked, cargo-chef can resolve different transitive dependency versions than what its Cargo.lock specifies, undermining the reproducibility improvement intended by this change.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 9ab8e33. Configure here.

@0xOsiris 0xOsiris merged commit 2733a25 into main May 13, 2026
8 checks passed
@0xOsiris 0xOsiris deleted the osiris/add-curl branch May 13, 2026 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants