Skip to content

fix: address zizmor security findings#140

Open
Daniel-Aaron-Bloom wants to merge 3 commits into
wormhole-foundation:mainfrom
Daniel-Aaron-Bloom:fix/zizmor-findings
Open

fix: address zizmor security findings#140
Daniel-Aaron-Bloom wants to merge 3 commits into
wormhole-foundation:mainfrom
Daniel-Aaron-Bloom:fix/zizmor-findings

Conversation

@Daniel-Aaron-Bloom

Copy link
Copy Markdown

Summary

This PR addresses zizmor security findings in the GitHub Actions workflow files.

Findings Fixed

  • dependabot-cooldown (.github/dependabot.yml): Added cooldown configuration (semver-patch: 3, semver-minor: 7, semver-major: 14 days) to the npm ecosystem entry.

  • dangerous-triggers (.github/workflows/dependabot-overrides.yml): Changed pull_request_target to pull_request to eliminate the fundamentally insecure workflow trigger. pull_request_target grants write access while running untrusted PR code; pull_request is safe for dependabot PRs (same-repo branches).

  • bot-conditions (.github/workflows/dependabot-overrides.yml): Changed github.actor to github.triggering_actor in the job condition to prevent actor spoofing.

  • unpinned-uses (.github/workflows/dependabot-overrides.yml): Pinned actions/checkout@v4 to full commit SHA actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2.

  • artipacked (.github/workflows/dependabot-overrides.yml): Added persist-credentials: false to the checkout step; git push now uses an explicit token via environment variable instead of stored credentials.

  • unpinned-uses (.github/workflows/sdk-type-check.yml): Pinned the reusable workflow wormhole-foundation/workflows/.github/workflows/wormhole-demo-typecheck.yml to commit SHA 30ad77bad7253e603b820f3037045fa0590e4151.

  • secrets-inherit (.github/workflows/sdk-type-check.yml): Removed secrets: inherit to stop unconditional secret propagation to the called workflow.

Test plan

  • Verify dependabot-overrides.yml still triggers correctly on dependabot PRs updating package.json
  • Verify sdk-type-check.yml type-check job runs successfully
  • Confirm zizmor CI passes on this PR

🤖 Generated with Claude Code

Daniel-Aaron-Bloom and others added 3 commits June 5, 2026 12:12
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ons)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
typecheck-latest:
uses: wormhole-foundation/workflows/.github/workflows/wormhole-demo-typecheck.yml@main
secrets: inherit
uses: wormhole-foundation/workflows/.github/workflows/wormhole-demo-typecheck.yml@30ad77bad7253e603b820f3037045fa0590e4151 # main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned to the version before the zizmor fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants