fix: address zizmor security findings#140
Open
Daniel-Aaron-Bloom wants to merge 3 commits into
Open
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ons) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
djb15
suggested changes
Jun 8, 2026
| typecheck-latest: | ||
| uses: wormhole-foundation/workflows/.github/workflows/wormhole-demo-typecheck.yml@main | ||
| secrets: inherit | ||
| uses: wormhole-foundation/workflows/.github/workflows/wormhole-demo-typecheck.yml@30ad77bad7253e603b820f3037045fa0590e4151 # main |
There was a problem hiding this comment.
Pinned to the version before the zizmor fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses zizmor security findings in the GitHub Actions workflow files.
Findings Fixed
dependabot-cooldown(.github/dependabot.yml): Added cooldown configuration (semver-patch: 3,semver-minor: 7,semver-major: 14days) to the npm ecosystem entry.dangerous-triggers(.github/workflows/dependabot-overrides.yml): Changedpull_request_targettopull_requestto eliminate the fundamentally insecure workflow trigger.pull_request_targetgrants write access while running untrusted PR code;pull_requestis safe for dependabot PRs (same-repo branches).bot-conditions(.github/workflows/dependabot-overrides.yml): Changedgithub.actortogithub.triggering_actorin the job condition to prevent actor spoofing.unpinned-uses(.github/workflows/dependabot-overrides.yml): Pinnedactions/checkout@v4to full commit SHAactions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2.artipacked(.github/workflows/dependabot-overrides.yml): Addedpersist-credentials: falseto the checkout step; git push now uses an explicit token via environment variable instead of stored credentials.unpinned-uses(.github/workflows/sdk-type-check.yml): Pinned the reusable workflowwormhole-foundation/workflows/.github/workflows/wormhole-demo-typecheck.ymlto commit SHA30ad77bad7253e603b820f3037045fa0590e4151.secrets-inherit(.github/workflows/sdk-type-check.yml): Removedsecrets: inheritto stop unconditional secret propagation to the called workflow.Test plan
dependabot-overrides.ymlstill triggers correctly on dependabot PRs updatingpackage.jsonsdk-type-check.ymltype-check job runs successfully🤖 Generated with Claude Code