Skip to content

fix: use u64::MAX as default Solana outbound limit#856

Open
bengtlofgren wants to merge 1 commit into
mainfrom
bengt/fix-ntt-add-chain-limit-consistency
Open

fix: use u64::MAX as default Solana outbound limit#856
bengtlofgren wants to merge 1 commit into
mainfrom
bengt/fix-ntt-add-chain-limit-consistency

Conversation

@bengtlofgren

@bengtlofgren bengtlofgren commented Apr 9, 2026

Copy link
Copy Markdown

Sets limits on solana/svm to match that of evm

Summary by CodeRabbit

  • Chores
    • Updated outbound limit configuration to use the maximum 64-bit unsigned integer value.

@coderabbitai

coderabbitai Bot commented Apr 9, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 42719e0a-8ae5-492e-914c-76b5bfea2a13

📥 Commits

Reviewing files that changed from the base of the PR and between 25a5c3f and b57fb71.

📒 Files selected for processing (2)
  • cli/src/constants.ts
  • cli/src/solana/deploy.ts

📝 Walkthrough

Walkthrough

A new constant U64_MAX representing the maximum unsigned 64-bit integer is introduced, and the Solana deployment configuration is updated to reference this constant instead of a hardcoded value for the outbound limit.

Changes

Cohort / File(s) Summary
Constant Definition
cli/src/constants.ts
Added exported U64_MAX constant set to 2n ** 64n - 1n to represent the maximum unsigned 64-bit integer value.
Configuration Update
cli/src/solana/deploy.ts
Imported U64_MAX and updated ntt.initialize configuration to use U64_MAX for outboundLimit instead of hardcoded 100000000n value.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 A constant grand for limits vast,
Two-sixty-four, at last, at last!
Where ones and zeros dance so bright,
The rabbit bounds with pure delight!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: introducing a u64::MAX constant for the Solana outbound limit to align cross-chain limit consistency.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bengt/fix-ntt-add-chain-limit-consistency

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bengtlofgren
bengtlofgren force-pushed the bengt/fix-ntt-add-chain-limit-consistency branch from ab088cd to b57fb71 Compare April 9, 2026 17:08

@kcsongor kcsongor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants