Sui Rate Limit Fixes#917
Open
mdulin2 wants to merge 3 commits into
Open
Conversation
mdulin2
force-pushed
the
sui-ntt-rate-limiter-fix
branch
from
June 26, 2026 17:47
465f092 to
ce2872a
Compare
kcsongor
previously approved these changes
Jun 30, 2026
djb15
reviewed
Jun 30, 2026
djb15
left a comment
djb15
left a comment
Collaborator
There was a problem hiding this comment.
The source changes look like we discussed and it's nice to see all the new tests. Just one question about whether we can make the test a bit more precise
djb15
approved these changes
Jun 30, 2026
kcsongor
approved these changes
Jul 13, 2026
mdulin2
force-pushed
the
sui-ntt-rate-limiter-fix
branch
from
July 16, 2026 21:13
49bfe80 to
a87eaf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two bugs in the rate limit code:
This PR fixes those bugs, and adds tests for the rate limiter.