Add peer check to the executeMsg (evm)#918
Open
mdulin2 wants to merge 4 commits into
Open
Conversation
mdulin2
changed the title
Collaborator
|
Resolves #890 |
djb15
previously approved these changes
Jun 30, 2026
djb15
left a comment
djb15
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me. Critically executeMsgInner has the correct visibility, attestationReceived still has the whenNotPaused modifier, and functionality is otherwise untouched
bemic
approved these changes
Jul 17, 2026
bemic
left a comment
bemic
left a comment
There was a problem hiding this comment.
The change does not affect functionality. New test cases added. Visibility and modifiers are matching the original implementation. Looks good to me.
johnsaigle
requested changes
Jul 17, 2026
johnsaigle
left a comment
johnsaigle
left a comment
Collaborator
There was a problem hiding this comment.
I think this needs a manual rebase before it'll pass CI. I'm unable to do it in the front-end
johnsaigle
approved these changes
Jul 17, 2026
johnsaigle
left a comment
johnsaigle
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good -- the PR just needs help to get through CI
djb15
approved these changes
Jul 17, 2026
…d not necessarily the original sender.
djb15
force-pushed
the
execute-msg-peer-check
branch
from
July 17, 2026 19:59
b162287 to
2505e0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performs the peer check on the
executeMsg()flow for EVM. I added an internal function with the logic in order to not duplicate the_verifyPeer()check in two spots.