refactor: new ticket count and onboarding init payload#921
Open
douglasgalico wants to merge 2 commits into
Open
refactor: new ticket count and onboarding init payload#921douglasgalico wants to merge 2 commits into
douglasgalico wants to merge 2 commits into
Conversation
johnsaigle
reviewed
Jul 3, 2026
| // XRPL caps an account at 250 tickets. | ||
| const MAX_TICKETS = 250; | ||
| // XRPL caps an account at 175 tickets. | ||
| const MAX_TICKETS = 175; |
Collaborator
There was a problem hiding this comment.
Can you provide some more context for this change, maybe in the PR description?
I'm unclear why this value is being modified. The docs seem to list 250 as the correct limit: https://xrpl.org/docs/concepts/accounts/tickets
Contributor
Author
There was a problem hiding this comment.
That's related to the Sequencer change at TicketEntry that grows from 27 -> 59 byes (as includes source_emitter). Then to keep under 10kIB MAX_PERMITTED_DATA_INCREASE for CPI create_account the TICKET_LEDGER_CAPACITY was reduced there from 250 to 170 (fixed the 175*)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.