Feat/decay rate#13
Merged
Merged
Conversation
thelostone-mc
force-pushed
the
feat/decay-rate
branch
8 times, most recently
from
August 4, 2025 07:13
776de71 to
302630a
Compare
thelostone-mc
force-pushed
the
feat/decay-rate
branch
from
August 5, 2025 04:40
302630a to
930c434
Compare
alexkeating
marked this pull request as ready for review
August 14, 2025 18:14
alexkeating
reviewed
Aug 15, 2025
thelostone-mc
force-pushed
the
feat/decay-rate
branch
4 times, most recently
from
August 18, 2025 06:10
c65808c to
83be3c2
Compare
alexkeating
reviewed
Aug 18, 2025
| uint256 expectedLoss = 250 ether; // 25% of 1000 ether | ||
| assertEq(balanceAfter - balanceBefore, expectedLoss, "50% decay rate should lose 25% of stake"); | ||
|
|
||
| // Test case 2: 100% decay rate (complete loss) |
Contributor
There was a problem hiding this comment.
Split each case into a separate test
| assertGe(finalAmount, 0, "Amount should not go negative"); | ||
| } | ||
|
|
||
| function test_DecayRateExamples() public { |
Contributor
There was a problem hiding this comment.
Use a more descriptive name test_FiftyPercentDecayRateAfterHalfofTheStakePeriod
thelostone-mc
force-pushed
the
feat/decay-rate
branch
from
August 18, 2025 12:26
83be3c2 to
b1947a8
Compare
alexkeating
approved these changes
Aug 18, 2025
|
Coverage after merging feat/decay-rate into main will be
Coverage Report
|
|||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/ScopeLift/fork-queries/issues/1