Fix deployment script to use correct deployer address#7
Merged
Conversation
|
Coverage after merging ethereum-deployment into main will be
Coverage Report
|
|||||||||||||||||||||||||
alexkeating
reviewed
Jul 10, 2025
|
|
||
| // Deploy the factory | ||
| factory = new QueryTypeStakerFactory(msg.sender, wTokenAddress); | ||
| factory = new QueryTypeStakerFactory(deployer, wTokenAddress); |
Contributor
There was a problem hiding this comment.
Isn't this the same as msg.sender as the deployment is wrapped in a broadcast initialized with the deployer private key
Contributor
Author
There was a problem hiding this comment.
No, if you use msg.sender it deploys with the forge deployment address. I only know this because I had deployed the contract, and it used the wrong owner address, so I had to fix and redeploy it.
alexkeating
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing script deploys the contract using the Forge deployment address rather than with the key provided.