Remove Portico route (ETH, wstETH, UDST Bridge) #3384
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for wormhole-connect-mainnet ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for wormhole-connect ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kev1n-peters
force-pushed
the
remote-portico-route
branch
from
fe61c40 to
eab1da3
Compare
kev1n-peters
force-pushed
the
remote-portico-route
branch
from
eab1da3 to
6321c3f
Compare
emreboga
reviewed
Mar 26, 2025
| // Parser for Portico transactions (appId === ETH_BRIDGE or USDT_BRIDGE) | ||
| // IMPORTANT: This is where we can add any customizations specific to Portico data | ||
| // that we have retrieved from WHScan API | ||
| const parsePorticoTx = useCallback( |
There was a problem hiding this comment.
We will stop showing portico route but if we remove the parsing it won't show previously created txs as well. Is that ok?
There was a problem hiding this comment.
I don't have a strong opinion on this. I guess a benefit of removing it is less code. But obviously older TXs won't be shown.
There was a problem hiding this comment.
@Wesleyleung What should we do here? Show old Portico route TXs in the history or remove support for that?
|
Holding off on merging this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.