feat: group assets in selector by owned vs all#3770
Merged
Conversation
✅ Deploy Preview for wormhole-connect-mainnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for wormhole-connect ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kyleleighton
force-pushed
the
PROD-612/token-balance
branch
from
September 4, 2025 14:46
0b084d1 to
a3c6389
Compare
kyleleighton
force-pushed
the
PROD-612/token-balance
branch
from
September 4, 2025 15:02
df7ab3a to
1c3b5fd
Compare
kyleleighton
force-pushed
the
PROD-612/token-balance
branch
from
September 4, 2025 15:44
10f561b to
48d6f35
Compare
kyleleighton
force-pushed
the
PROD-612/token-balance
branch
from
September 4, 2025 15:46
48d6f35 to
b9d198b
Compare
kyleleighton
force-pushed
the
PROD-612/token-balance
branch
from
September 4, 2025 15:46
b9d198b to
4de6a0a
Compare
bradleyplaydon
approved these changes
Sep 4, 2025
priyajeet
reviewed
Sep 4, 2025
| } | ||
|
|
||
| if (price > 0 && price < 0.01) { | ||
| return '<$0.01'; |
Collaborator
There was a problem hiding this comment.
It probably doesn't matter for now since its all USD....but I would say still use the Intl.NumberFormat here for the 0.01, can prefix it with <$.
Passing in { maximumFractionDigits: n } to NumberFormat can help.
| isFetchingBalance={props.isFetchingBalances} | ||
| /> | ||
| <Fragment key={token.key}> | ||
| <TokenSectionHeader |
Collaborator
There was a problem hiding this comment.
Can this move inside the in which case you won't need wrapping Fragment/key? Might need hasHeader prop added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/wormholelabs/issue/PROD-611/possibly-show-all-tokens-in-the-source-asset-picker-when-connected-to
https://linear.app/wormholelabs/issue/PROD-612/possibly-show-something-other-than-dollar0-as-the-token-balance-amount