chore: change build lib to output library in esm#3771
Merged
Conversation
✅ Deploy Preview for wormhole-connect ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for wormhole-connect-mainnet ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
priyajeet
changed the title
priyajeet
commented
Sep 5, 2025
priyajeet
commented
Sep 5, 2025
priyajeet
commented
Sep 5, 2025
priyajeet
commented
Sep 5, 2025
bradleyplaydon
previously approved these changes
Sep 17, 2025
priyajeet
force-pushed
the
priyajeet/connect-lib-build
branch
from
September 18, 2025 03:15
ac9953d to
a5d82ac
Compare
priyajeet
marked this pull request as ready for review
September 19, 2025 04:39
bradleyplaydon
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In connect, the
libbuild is what builds the package like an npm module to be consumed by parent projects, for eg Portal. However thelibfolder ends up with mangled/minified/chunked code that is hard to debug.This PR adds a new build
minimalcommand to do whatever thelibbuild does and additionally preserves all modules disabling any mangling/minifying/chunking.TODOS: