fix: missing dependency#996
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughA new runtime dependency Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
In our pnpm project, I was running into issues like
Failed to load required packages Error: Protocol Evm for protocol WormholeCore has already registered.automaticCircleBridge.tsimports@wormhole-foundation/sdk-evm-tokenbridge(side-effect import for protocolregistration) but the
package.jsonnever declared it as a dependency.In pnpm strict mode, this causes the import to resolve from a different context, loading a duplicate copy of sdk-evm-core which tries to re-register the Evm/WormholeCore protocol on a shared singleton.
Summary by CodeRabbit