Skip to content

fix: missing dependency#996

Open
AlexBHarley wants to merge 1 commit into
wormhole-foundation:mainfrom
AlexBHarley:fix/missing-dependency
Open

fix: missing dependency#996
AlexBHarley wants to merge 1 commit into
wormhole-foundation:mainfrom
AlexBHarley:fix/missing-dependency

Conversation

@AlexBHarley

@AlexBHarley AlexBHarley commented Mar 28, 2026

Copy link
Copy Markdown

In our pnpm project, I was running into issues like Failed to load required packages Error: Protocol Evm for protocol WormholeCore has already registered.

automaticCircleBridge.ts imports @wormhole-foundation/sdk-evm-tokenbridge (side-effect import for protocol
registration) but the package.json never declared it as a dependency.

In pnpm strict mode, this causes the import to resolve from a different context, loading a duplicate copy of sdk-evm-core which tries to re-register the Evm/WormholeCore protocol on a shared singleton.

Summary by CodeRabbit

  • Chores
    • Added new runtime dependency for EVM token bridge support.

@coderabbitai

coderabbitai Bot commented Mar 28, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dd25ee36-6e65-4f11-8a6b-3dd0adeac82c

📥 Commits

Reviewing files that changed from the base of the PR and between 86bd4d3 and 3de9cad.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • platforms/evm/protocols/cctp/package.json

📝 Walkthrough

Walkthrough

A new runtime dependency @wormhole-foundation/sdk-evm-tokenbridge@1.20.0 was added to the CCTP protocol package's dependencies. No other configuration, build setup, or API changes were made.

Changes

Cohort / File(s) Summary
Dependency Addition
platforms/evm/protocols/cctp/package.json
Added @wormhole-foundation/sdk-evm-tokenbridge at version 1.20.0 as a runtime dependency.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A token bridge now joins the fray,
A dependency added today,
The CCTP grows with might,
New SDK tools shine bright,
One small line, one grand way! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding a missing dependency declaration to package.json to resolve a runtime error in pnpm strict mode.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant