node: Extend flow cancel by configuring allow-list of chain ID pairs ("pipes") #4229
+289
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnsaigle
changed the title
johnsaigle
force-pushed
the
flow-cancel-pipes
branch
from
4303203 to
35e937b
Compare
djb15
reviewed
Jan 27, 2025
| ) | ||
| // Process the next pending transfer | ||
| continue | ||
| } |
There was a problem hiding this comment.
We've lost this continue skipping logic with this PR if an error occurs...is this deliberate?
There was a problem hiding this comment.
No I don't think it was, thanks for the catch. I'm not totally sure if it matters but to make the changes here as minimal as they can be, I'll add a continue in the if...err check for tryAddFlowCancelTransfer()
There was a problem hiding this comment.
The latest commits should restore this functionality. Previously the behaviour was to continue if flow cancel is enabled and if the attempt to add the transfer resulted in an error. That should be the same behaviour in the new version, but implemented differently.
johnsaigle
requested review from
mdulin2,
pleasew8t,
bruce-riley,
evan-gray and
panoel
as code owners
- Add a concept of "pipes" which consist of a pair of chains - Add field in the Governer that enables flow cancel only for "pipes" which are explicitly enabled - Set the Eth-Sui pipe as the only flow cancel-enabled pair. Sui is the only chain with frequent governor congestion so it is the only one that really needs the Flow Cancel capabilities. Ethereum is the main chain that Sui is interacting with in terms of volume moving in and out of Sui. - Refactor calling sites for flow cancel transfer functions so that all checks are done in one place. (Should help prevent bugs where only one calling site is updated.)
- Add unit tests to ensure that the flow cancel feature works iff valid pipes are configured - Adds unit tests for the pipe type (validity, equality between two pipes) - Modifies pipe.equals() to always return false for invalid pipes
johnsaigle
force-pushed
the
flow-cancel-pipes
branch
from
54d16d7 to
2c1ba16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.