-
Notifications
You must be signed in to change notification settings - Fork 775
Node: Reobserve with custom endpoint #4260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node: Reobserve with custom endpoint #4260
Conversation
d399f23
to
ccaca21
Compare
da65817
to
880d508
Compare
456fed5
to
e724478
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, made some suggestions to simplify the code.
Note: Once #4116 is merged, the EVM version of |
d95a41d
to
bf5dc69
Compare
9a3e0db
to
34f46b2
Compare
Now that #4116 is merged, I added a check to make sure the custom endpoint URL points at the correct EVM chain. |
This PR adds support for the
reobserve-with-endpoint
admin command.Don't be alarmed by the size of this PR. 900+ lines are generated protobuf code. Also the code in
handleReobservationRequest
in Solana and EVM is mostly just code moved into a function so it can be reused.Tests performed: