Skip to content

Node: Reobserve with custom endpoint #4260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bruce-riley
Copy link
Contributor

@bruce-riley bruce-riley commented Feb 7, 2025

This PR adds support for the reobserve-with-endpoint admin command.

Don't be alarmed by the size of this PR. 900+ lines are generated protobuf code. Also the code in handleReobservationRequest in Solana and EVM is mostly just code moved into a function so it can be reused.

Tests performed:

  • Sepolia new observations still works
  • Sepolia standard reobservation still works
  • Sepolia with custom endpoint works
  • Solana new observations still works
  • Solana standard reobservation by account still works
  • Solana standard reobservation by transaction ID still works
  • Solana by account ID with custom endpoint works
  • Solana by transaction ID with custom endpoint works
  • Chain that is not enabled returns "chain X does not support reobservation by endpoint"
  • Chain other than Solana or EVM that is enabled returns "chain X does not support reobservation by endpoint"
  • Pointing at the wrong EVM chain returns "evm chain ID miss match".

@bruce-riley bruce-riley force-pushed the node_reobserve_with_endpoint branch 5 times, most recently from d399f23 to ccaca21 Compare February 11, 2025 16:28
@bruce-riley bruce-riley marked this pull request as ready for review February 12, 2025 13:44
@bruce-riley bruce-riley force-pushed the node_reobserve_with_endpoint branch 2 times, most recently from da65817 to 880d508 Compare February 12, 2025 15:20
@bruce-riley bruce-riley force-pushed the node_reobserve_with_endpoint branch from 456fed5 to e724478 Compare February 18, 2025 17:57
Copy link
Contributor

@johnsaigle johnsaigle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, made some suggestions to simplify the code.

@bruce-riley
Copy link
Contributor Author

bruce-riley commented Feb 20, 2025

Note: Once #4116 is merged, the EVM version of Reobserve should be updated to call verifyEvmChainID before performing the reobservation.

johnsaigle
johnsaigle previously approved these changes Feb 20, 2025
@bruce-riley bruce-riley force-pushed the node_reobserve_with_endpoint branch from 9a3e0db to 34f46b2 Compare February 25, 2025 13:29
@bruce-riley
Copy link
Contributor Author

Now that #4116 is merged, I added a check to make sure the custom endpoint URL points at the correct EVM chain.

@bruce-riley bruce-riley merged commit 4706a9f into wormhole-foundation:main Feb 26, 2025
31 checks passed
@bruce-riley bruce-riley deleted the node_reobserve_with_endpoint branch February 26, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants