-
Notifications
You must be signed in to change notification settings - Fork 817
node: Add support for delegated guardian sets #4628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
nvsriram
wants to merge
80
commits into
main
Choose a base branch
from
feature/delegated-guardian-sets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed wrapper instead
55693cf to
5396cbd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for delegated guardian sets:
WormholeDelegatedGuardiansEVM smart contract configures delegated guardians per chain iddelegated-guardians-configadmin command to update delegated guardian setDelegateObservation— emitted by delegated guardiansDelegateGuardianChainConfiglocally (updated every 15 seconds by watcher) and references that to handle messages (see below for more details) from delegated chainsGlossary of Terms
DelegatedGuardianSetconfigured for it in theWormholeDelegatedGuardiansEVM smart contract. Conversely, a chain is delegated if aDelegatedGuardianSetis configured for it.DelegatedGuardianSetfor the chain.DelegatedGuardianSetfor the chain.Note
Delegated Guardian and Canonical Guardian are scoped terms; by default they mean the delegated/canonical guardian for the message’s
EmitterChain.Updated Message Flow
This flow is applicable for delayed messages and reobservations as well.
The message flow is unchanged for undelegated chains. The following flow describes the updated flow for delegated chains:
For Delegated Guardian
MessagePublicationviamsgCcontinueif unsuccessfulMessagePublicationintoDelegateObservationand broadcasts itDelegateObservationfor this chainFor Canonical Guardian
MessagePublicationfrom local watcher (if exists)DelegateObservationviadelegateObsvC— verifies observation is from delegated guardian for this chainDelegateObservationin localdelegateObservationMapDelegateObservationintoMessagePublicationand runs it through main message processing loop.This PR is currently in draft since there are a few TODOs (labelled
TODO(delegated-guardian-sets) that require resolution