node: Add ability to pass custom headers to Sui gRPC#4890
Draft
djb15 wants to merge 1 commit into
Draft
Conversation
djb15
requested review from
SEJeff,
bemic,
evan-gray,
johnsaigle,
kcsongor,
mdulin2,
panoel and
pleasew8t
as code owners
July 3, 2026 14:29
johnsaigle
reviewed
Jul 6, 2026
| }, nil | ||
| } | ||
|
|
||
| func parseGrpcHeaderSpecs(headerSpecs []string) (metadata.MD, error) { |
Contributor
There was a problem hiding this comment.
suggestion: I think some of this logic could be replaced by using cobra's built-in parsing.
This is an example that parses key-value pairs:
var labels map[string]string
cmd.Flags().StringToStringVar(
&labels,
"label",
nil,
"key-value labels, e.g. --label env=prod,team=infra",
)It might make more sense to put this in a the cmd/ code as well since this is related to CLI input parsing rather than Sui client code.
djb15
marked this pull request as draft
July 16, 2026 20:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving to draft for the time being. Guardians should be able to work around this, we can consider reopening soon if this continues to be a blocker.