Skip to content

ethereum: fix helper scripts; stop sourcing env files#4913

Draft
bemic wants to merge 5 commits into
wormhole-foundation:mainfrom
bemic:fix-ethereum-upgrade-scritps
Draft

ethereum: fix helper scripts; stop sourcing env files#4913
bemic wants to merge 5 commits into
wormhole-foundation:mainfrom
bemic:fix-ethereum-upgrade-scritps

Conversation

@bemic

@bemic bemic commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary

EVM deployment, registration, and upgrade helpers previously sourced repository .env files, causing configuration data to execute as shell code in the release operator's process.

This change removes executable env-file loading. Configuration is now supplied
through the operator environment, while devnet reads only the required
registration values from .env as data.

The change also restores the previously unreachable upgrade workflow. The
verifier distinguishes a confirmed bytecode mismatch from operational errors,
new implementations are verified before governance, and generated governance
data is submitted as one quoted argument.

Compatibility

Operators must export the required configuration from a trusted shell, CI
environment, secret manager, or release runner. Files under ethereum/env may
be used as reviewed references but must not be sourced.

Testing

  • make test-release-helpers
  • make test

@johnsaigle johnsaigle self-assigned this Jul 23, 2026
@johnsaigle
johnsaigle self-requested a review July 23, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants