ethereum: fix helper scripts; stop sourcing env files#4913
Draft
bemic wants to merge 5 commits into
Draft
Conversation
johnsaigle
self-requested a review
July 23, 2026 11:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EVM deployment, registration, and upgrade helpers previously sourced repository
.envfiles, causing configuration data to execute as shell code in the release operator's process.This change removes executable env-file loading. Configuration is now supplied
through the operator environment, while devnet reads only the required
registration values from
.envas data.The change also restores the previously unreachable upgrade workflow. The
verifier distinguishes a confirmed bytecode mismatch from operational errors,
new implementations are verified before governance, and generated governance
data is submitted as one quoted argument.
Compatibility
Operators must export the required configuration from a trusted shell, CI
environment, secret manager, or release runner. Files under
ethereum/envmaybe used as reviewed references but must not be sourced.
Testing
make test-release-helpersmake test