canton: fix devnet Dockerfile for the current core DAR layout#42
Merged
Merged
Conversation
The build stage still copied only core/ and test/ and referenced wormhole-core-0.1.0.dar, but core is now versioned 0.2.0 and canton/test's data-dependencies moved to the vendored ../dars/ directory (fee payments, #40) -- the image could not have built as written. Copy dars/ before the build and reference the correct 0.2.0 DAR filename. Verified core + test build via dpm and produce exactly the filenames this Dockerfile now references; the Docker build itself isn't runnable in this devcontainer (no Docker), so CI/a real build host should confirm the image build end to end. Claude-Session: https://claude.ai/code/session_01VFr5RtBKysvjdRN2nKmhMV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
canton/dars/, and referencedwormhole-core-0.1.0.dar-- but core is now versioned0.2.0andcanton/test's data-dependencies moved to the vendored../dars/directory as of canton: token-standard fee payments #40. The image could not have built as written.dars/before the build stage and fixes the copied DAR filename to0.2.0.This is a prerequisite extracted from the (not-yet-merged)
canton-keyed-nttbranch's Dockerfile changes, split out because it's a core-only fix independent of NTT -- part of the effort to migrate Canton NTT tonative-token-transfers(separate PR(s) to follow).Test plan
dpm build --allproduces exactlycore/.daml/dist/wormhole-core-0.2.0.darandtest/.daml/dist/wormhole-core-test-0.1.0.dar-- matching what the Dockerfile now referenceshttps://claude.ai/code/session_01VFr5RtBKysvjdRN2nKmhMV