canton: guardianGovernance fee-pin#46
Merged
bengtlofgren merged 1 commit intoJul 16, 2026
Merged
Conversation
kcsongor
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Emitter.PublishMessage,EmitterRegistry.RegisterEmitter, andReplayRootRegistry.ClaimReplayRootauthenticate a caller-suppliedCoreStatecontract before charging a fee through it, but the check only ever compared theoperatorfield.operatordoes not determineguardianGovernance(the actual fee-custody trust anchor) — a genuine or compromised operator can co-sign a second, fully validCoreStatearound an attacker-controlledguardianGovernance/feeRecipient, and the old check would accept it, redirecting real fee payments to the attacker. This was proven with a working PoC during review.This adds:
GetGuardianGovernance— a nonconsuming read choice onCoreStateexposing itsguardianGovernancefield, mirroring the existingGetOperatorpin idiom.guardianGovernanceanchor field onEmitter/EmitterRegistry/ReplayRootRegistry(not a signatory — a pure trust reference, the same roleoperatoralready plays).GetGuardianGovernanceon the caller-suppliedCoreStateand asserts it matches the committed anchor, before charging.Test plan
dpm buildclean on both packagesdpm test: 44/44 passing, including 3 new regression tests that build a genuine forgedCoreState(real operator, rogue governance) and confirm each charge fails specifically on the new"guardianGovernance mismatch"check