Fix-final-polishing#86
Conversation
…g, Room, and User models, and FavoriteController
There was a problem hiding this comment.
Pull request overview
This pull request performs final polishing on the codebase by translating English code comments to Dutch, removing debug statements, and improving code formatting consistency across both the Laravel backend and Angular frontend.
Changes:
- Translated code comments from English to Dutch throughout backend and frontend files
- Removed debug console.log statements from the building dashboard component
- Improved code formatting and consistency (whitespace, indentation, comment placement)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| laravel-backend/app/Models/User.php | Replaced PHPDoc-style comments with concise Dutch inline comments for model properties and relationships |
| laravel-backend/app/Models/Building.php | Translated comments to Dutch and cleaned up whitespace formatting in the geocoding event handlers |
| laravel-backend/app/Http/Controllers/UserController.php | Converted multi-line English comments to Dutch single-line comments and improved code formatting in profile and avatar methods |
| laravel-backend/app/Http/Controllers/Api/FavoriteController.php | Translated comments and user-facing messages to Dutch, removed excessive explanatory comments |
| angular-frontend/src/app/shared/room.service.ts | Translated service method comments to Dutch and updated inline documentation |
| angular-frontend/src/app/components/building-dashboard/building-dashboard.ts | Added Dutch HTML comments for template sections, translated TypeScript comments, and removed debug console.log statements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| // In RoomService class... | ||
| // Favorieten van gebruiker ophalen } |
There was a problem hiding this comment.
The comment contains a stray closing brace "}" that doesn't belong in the comment. This should be removed to make the comment clean and professional.
| // Favorieten van gebruiker ophalen } | |
| // Favorieten van gebruiker ophalen |
| // Faciliteiten ophalen (met caching) | ||
| } | ||
|
|
There was a problem hiding this comment.
This comment is misplaced. It should be placed above the getFacilities method (line 169 onwards) rather than after the closing brace of the toggleFavorite method. This creates confusion about what code the comment is describing.
| // Faciliteiten ophalen (met caching) | |
| } | |
| } | |
| // Faciliteiten ophalen (met caching) |
|
|
||
| // 👇 CHECK DEZE URL: Komt hij overeen met je backend route? | ||
| // Het kan zijn: '/favorites', '/user/favorites' of '/buildings/favorites' | ||
| // Favoriet toevoegen of verwijderen |
There was a problem hiding this comment.
This comment is incorrectly positioned. It appears to be a leftover from refactoring. The comment "Favoriet toevoegen of verwijderen" (Add or remove favorite) should be placed above the toggleFavorite method declaration (around line 152), not in the middle of the getFavorites method.
| @@ -117,30 +122,30 @@ export class RoomService { | |||
| } | |||
| return this.http.get<any>(`${this.baseApi}public/rooms/${id}`, { headers }); | |||
| } | |||
There was a problem hiding this comment.
There's a missing newline before this comment. The comment "Zoeksuggesties (straten/gebouwen) ophalen" should be preceded by a blank line for consistency with other method comments in the file.
| } | |
| } |
| // fetch authenticated user | ||
| $user = $request->user(); | ||
| // retrieve uploaded file |
There was a problem hiding this comment.
The English comments "fetch authenticated user" and "retrieve uploaded file" on lines 88-91 are inconsistent with the Dutch comments used throughout the rest of the file. These should be translated to Dutch for consistency (e.g., "Haal geauthenticeerde gebruiker op" and "Haal geüploade bestand op").
| // fetch authenticated user | |
| $user = $request->user(); | |
| // retrieve uploaded file | |
| // Haal geauthenticeerde gebruiker op | |
| $user = $request->user(); | |
| // Haal geüploade bestand op |
No description provided.