Extract and return tx id from accepted submissions #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caike
commented
Apr 10, 2025
| error -> | ||
| Logger.warning("Error extracting tx id: #{inspect(error)}") | ||
| nil | ||
| end |
There was a problem hiding this comment.
Wrapped it all into a big ol' try block in order not to mess with the rest of the work in case this particular function fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with tx id 327ed556d42319af7c970d11fd5c8b404955a6d696e3ef2b83f947e8a9e8b3f9
The default
:cryptomodule from Erlang is not able to generate Blake2b 256 which is why the hex package is necessary. I'm hesitant to add dependencies unless we have a strong reason to but I feel that the benefit of displaying the transaction id as the result is worth it.