Add support for multi item effect parsing

proto/common.proto

@@ -25,7 +25,7 @@ message ProtoVersion {
 	// protos need to define an api_version field so that the UI code knows
 	// to up-convert these protos to the new format whenever api_version is
 	// missing (0) or lower than current_version_number.
-	option (current_version_number) = 2;
+	option (current_version_number) = 3;
 
 	// The actual field value is only used within unit tests.
 	int32 saved_version_number = 1;

proto/db.proto

@@ -23,7 +23,7 @@ message SimEnchant {
 	string name = 2; // Only needed for unit tests.
 	ItemType type = 3; // Only needed for unit tests.
 	repeated double stats = 4;
-	ItemEffect enchant_effect = 5;
+	repeated ItemEffect enchant_effects = 5;
 }
 
 // Contains only the Item info needed by the sim.
@@ -45,7 +45,7 @@ message SimItem {
 	int32 set_id = 12;
 
 	map<int32, ScalingItemProperties> scaling_options = 13; // keys are the all ItemLevelState variants that this item could potentially have
-	ItemEffect item_effect = 14;
+	repeated ItemEffect item_effects = 14;
 }
 
 message Consumable {

proto/spell.proto

@@ -11,11 +11,12 @@ message ScalingItemEffectProperties {
 	map<int32, double> stats = 1;
 }
   message ItemEffect {
-	int32            buff_id         = 1;
-	string buff_name = 6;
-	int32            effect_duration_ms = 2;  // milliseconds
+	int32  buff_id  		     = 1;
+	string buff_name 			 = 6;
+	int32  effect_duration_ms    = 2;  // milliseconds
+	int32  max_cumulative_stacks = 7;
 	// Keyed to itemlevelstate
-	map<int32, ScalingItemEffectProperties> scaling_options        = 3;
+	map<int32, ScalingItemEffectProperties> scaling_options = 3;
 
 	oneof effect {
 	  ProcEffect  proc   = 4;
@@ -29,11 +30,11 @@ message ScalingItemEffectProperties {
   }
 
   message ProcEffect {
-	int32       icd_ms         = 1;  // internal cooldown in milliseconds
+	int32 icd_ms = 1;  // internal cooldown in milliseconds
 	oneof procRate {
 		double proc_chance = 2;  // e.g. 0.20 = 20%
-		double ppm = 3;
-		RppmProc rppm = 4;
+		double ppm 		   = 3;
+		RppmProc rppm      = 4;
 	}
   }
 

proto/ui.proto

@@ -99,7 +99,7 @@ message UIItem {
 
 	FactionRestriction faction_restriction = 25;
 	map<int32, ScalingItemProperties> scaling_options = 29; // keys are the other ilvl variants that this item could potentially have
-	ItemEffect item_effect = 30;
+	repeated ItemEffect item_effects = 30;
 }
 
 enum Expansion {
@@ -235,7 +235,7 @@ message UIEnchant {
 	// Classes that are allowed to use the enchant. Empty indicates no special class restrictions.
 	repeated Class class_allowlist = 11;
 	Profession required_profession = 12;
-	ItemEffect enchant_effect = 14;
+	repeated ItemEffect enchant_effects = 14;
 }
 
 message UIGem {