P5 Mage Fixes and BiS#1387
Merged
1337LutZ merged 1 commit intowowsims:masterfrom Apr 28, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the simulation of a specific trinket bug involving Alter Time and temporary stacking buffs, ensuring the sim more accurately matches live game behavior for affected trinkets. It introduces a new configuration option to selectively enable this bug emulation only for confirmed items. As a result, there are minor updates to DPS results across mage specializations, reflecting the improved accuracy.
Phase 5 BiS Lists
Tier 16 Bug Fix
Tier 16 Frost 2pc bonus was incorrect. Buff was immediately granted and consumed by the proc'ing spell, and offered no benefit. This is now corrected.
Black Blood of Y'Shaarj trinket was incorrectly assumed to have the same bug as Wushoolay's Lightning. PTR testing confirms the trinket works with Alter and does not need the bugged interaction.
Bug fix and simulation accuracy improvements:
Added a
BuggedAlterTimeRestoreoption toTemporaryStatBuffWithStacksConfig, allowing the simulation to reproduce a live-game bug where certain stacking buffs expire during Alter Time and are only restored for one tick before being removed. This is only enabled for trinkets where the bug is confirmed (e.g., Wushoolay's Final Choice). (sim/core/aura_helpers.go,Simulation results update:
Updated DPS results for Arcane, Fire, and Frost mage test cases to reflect the more accurate simulation, with generally small changes in DPS and TPS values. (
sim/mage/arcane/TestArcane.results,sim/mage/fire/TestFire.results,sim/mage/frost/TestFrost.results) [[1]](diffhunk://#diff-