Batch Sim Re-Work#911
Merged
NerdEgghead merged 28 commits intomasterfrom Oct 9, 2025
Merged
Conversation
On branch feature/batch-sim Changes to be committed: modified: proto/api.proto modified: ui/core/components/individual_sim_ui/bulk/bulk_item_picker.tsx modified: ui/core/components/individual_sim_ui/bulk/utils.ts modified: ui/core/components/individual_sim_ui/bulk_tab.tsx modified: ui/core/components/raid_sim_action.tsx modified: ui/core/components/suggest_reforges_action.tsx modified: ui/core/individual_sim_ui.tsx modified: ui/death_knight/blood/sim.ts modified: ui/death_knight/frost/sim.ts modified: ui/death_knight/unholy/sim.ts modified: ui/druid/balance/sim.ts modified: ui/druid/feral/sim.ts modified: ui/druid/guardian/sim.ts modified: ui/hunter/beast_mastery/sim.ts modified: ui/hunter/marksmanship/sim.ts modified: ui/hunter/survival/sim.ts modified: ui/mage/arcane/sim.tsx modified: ui/mage/fire/sim.tsx modified: ui/mage/frost/sim.ts modified: ui/monk/brewmaster/sim.ts modified: ui/monk/windwalker/sim.ts modified: ui/paladin/protection/sim.ts modified: ui/paladin/retribution/sim.ts modified: ui/priest/shadow/sim.ts modified: ui/rogue/assassination/sim.ts modified: ui/rogue/combat/sim.ts modified: ui/rogue/subtlety/sim.ts modified: ui/shaman/elemental/sim.ts modified: ui/shaman/enhancement/sim.ts modified: ui/warlock/affliction/sim.tsx modified: ui/warlock/demonology/sim.tsx modified: ui/warlock/destruction/sim.ts modified: ui/warrior/arms/sim.ts modified: ui/warrior/fury/sim.ts modified: ui/warrior/protection/sim.ts
github-actions
Bot
added
Death Knight
Druid
Hunter
Mage
Paladin
Priest
Rogue
Shaman
Warlock
Warrior
Monk
labels
1337LutZ
reviewed
Oct 4, 2025
| this.simUI.reforger.setIncludeGems(TypedEvent.nextEventID(), true); | ||
|
|
||
| if (RelativeStatCap.hasRoRo(this.simUI.player) && this.simUI.reforger.defaultRelativeStatCap) { | ||
| this.simUI.reforger.relativeStatCap = new RelativeStatCap(this.simUI.reforger.defaultRelativeStatCap, this.simUI.player, this.simUI.player.getClass()); |
There was a problem hiding this comment.
I think this should only be created if there's no relativeStatCap set (So if you edited the reforge settings in your current session to something other than defautl).
Because you can already have this.relativeStatCap?.forcedHighestStat.getStat() and this would be overwritten by this code.
1337LutZ
reviewed
Oct 4, 2025
| await this.simUI.sim.updateCharacterStats(TypedEvent.nextEventID()); | ||
| this.simUI.reforger.setIncludeGems(TypedEvent.nextEventID(), false); | ||
| if (RelativeStatCap.hasRoRo(this.simUI.player) && this.simUI.reforger.defaultRelativeStatCap) { | ||
| this.simUI.reforger.relativeStatCap = new RelativeStatCap(this.simUI.reforger.defaultRelativeStatCap, this.simUI.player, this.simUI.player.getClass()); |
On branch feature/batch-sim Changes to be committed: modified: ui/core/components/individual_sim_ui/bulk_tab.tsx modified: ui/core/components/raid_sim_action.tsx
On branch feature/batch-sim Changes to be committed: modified: ui/core/components/individual_sim_ui/bulk_tab.tsx
On branch feature/batch-sim Changes to be committed: modified: ui/core/components/individual_sim_ui/bulk/bulk_sim_results_renderer.tsx modified: ui/core/components/individual_sim_ui/bulk_tab.tsx modified: ui/core/sim.ts
On branch feature/batch-sim Changes to be committed: modified: package-lock.json
On branch feature/batch-sim Changes to be committed: modified: ui/core/components/individual_sim_ui/bulk_tab.tsx
MainHand slot. On branch feature/batch-sim Changes to be committed: modified: ui/core/components/individual_sim_ui/bulk_tab.tsx
equipping a gear set post-run. This fixes a bug where a repeat batch run after equipping a solution could include 2x of the same trinket or ring as valid options. On branch feature/batch-sim Changes to be committed: modified: ui/core/components/individual_sim_ui/bulk/bulk_item_picker_group.tsx modified: ui/core/components/individual_sim_ui/bulk_tab.tsx
1H items are present. On branch feature/batch-sim Changes to be committed: modified: ui/core/components/individual_sim_ui/bulk_tab.tsx
On branch feature/batch-sim Changes to be committed: modified: ui/core/components/individual_sim_ui/bulk_tab.tsx
On branch feature/batch-sim Changes to be committed: modified: ui/core/components/gear_picker/item_list.tsx modified: ui/core/individual_sim_ui.tsx
…to feature/batch-sim
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.