Skip to content

Add tracking #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1337LutZ merged 6 commits into from
Oct 13, 2025
Merged

Add tracking #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1bdda56
WIP: Add tracking
1337LutZ Oct 9, 2025
e2ddb3b
Add more events
1337LutZ Oct 10, 2025
0f12127
Merge branch 'master' into feature/tracking
1337LutZ Oct 10, 2025
87176c2
Change event value to event_value for custom definition
1337LutZ Oct 11, 2025
82d6ee0
Merge branch 'master' into feature/tracking
1337LutZ Oct 13, 2025
737ef83
Add translation change
1337LutZ Oct 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assets/locales/en/translation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,8 @@
"waist": "Waist",
"legs": "Legs",
"feet": "Feet",
"finger_1": "Finger 1",
"finger_2": "Finger 2",
"finger_1": "Ring 1",
"finger_2": "Ring 2",
"trinket_1": "Trinket 1",
"trinket_2": "Trinket 2",
"main_hand": "Main Hand",
Expand Down
8 changes: 8 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"@protobuf-ts/runtime": "2.9.1",
"@types/bootstrap": "^5.2.10",
"@types/eslint": "^8.56.10",
"@types/gtag.js": "^0.0.20",
"@types/minimist": "^1.2.5",
"@types/node": "^22.0.0",
"@types/uuid": "^10.0.0",
Expand Down
11 changes: 11 additions & 0 deletions ui/core/components/detailed_results.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import i18n from '../../i18n/config';
import { ref } from 'tsx-vanilla';
import { isDevMode } from '../utils';
import { IndividualSimUI } from '../individual_sim_ui';
import { trackEvent } from '../../tracking/utils';

type Tab = {
isActive?: boolean;
Expand Down Expand Up @@ -303,11 +304,21 @@ export class DetailedResults extends Component {

const simButton = simButtonRef.value!;
simButton?.addEventListener('click', () => {
trackEvent({
action: 'sim',
category: 'simulate',
label: 'once',
});
this.simUI?.runSimOnce();
});

const deathButton = deathButtonRef.value!;
deathButton?.addEventListener('click', () => {
trackEvent({
action: 'sim',
category: 'simulate',
label: 'death',
});
if (this.latestDeathSeeds.length > 1) {
this.simUI?.sim.setFixedRngSeed(TypedEvent.nextEventID(), Number(this.latestDeathSeeds.pop()));
this.recentlyEditedSeed = true;
Expand Down
Loading
Loading